Swag at permissions changes #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@mkimberlin Did you intend to merge this into feature-2064/admin-ui-page? |
@ZacharyKlein I did. The permissions weren't loaded into global state, just local state in the EditPermissionsPage. So, in order to provide the selector method that I promised @S78901, I had to come off of their branch. |
mkimberlin
requested review from
ZacharyKlein,
pieperm,
Samibanley,
S78901 and
borinquenkid
3 tasks
pieperm
reviewed
Mar 21, 2024
server/src/main/java/com/objectcomputing/checkins/services/permissions/Permission.java
Show resolved
Hide resolved
server/src/main/java/com/objectcomputing/checkins/services/permissions/Permission.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/objectcomputing/checkins/security/permissions/Permissions.java
Outdated
Show resolved
Hide resolved
pieperm
approved these changes
Mar 22, 2024
S78901
approved these changes
Mar 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talked to Syd last night and ended up taking a swag at this while my family was gone and I was bored. 🤣 It ended up coming together pretty quickly. @S78901 had most of it there already, and it was really just a matter of writing a couple of map calls to get it going.
Just in case @S78901 wanted to preserve any of that code, I have left the original page in place and copied it over to PermissionsPage. However, if I didn't forget anything, it could be removed.