Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnDefault.java:33-38: Rename OnDefault and OnVersioned... #2389

Closed
0pdd opened this issue Aug 14, 2023 · 0 comments · Fixed by #2391
Closed

OnDefault.java:33-38: Rename OnDefault and OnVersioned... #2389

0pdd opened this issue Aug 14, 2023 · 0 comments · Fixed by #2391
Assignees
Milestone

Comments

@0pdd
Copy link

0pdd commented Aug 14, 2023

The puzzle 2381-b6d409bc from #2381 has to be resolved:

* @todo #2381:30min Rename OnDefault and OnVersioned objects.
* Both seems misleading: OnVersioned replaces tag in given object with hash,
* OnDefault checks if given object contains version and if not - put the
* default one.
* It seems the names of the objects don't match with their behaviour.
* Suggestion: OnVersioned -> OnReplaced, OnDefault -> OnVersioned

The puzzle was created by maxonfjvipon on 14-Aug-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants