Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main.java:174-176: Make type casting when logging an app... #2645

Closed
0pdd opened this issue Nov 29, 2023 · 3 comments · Fixed by #2799
Closed

Main.java:174-176: Make type casting when logging an app... #2645

0pdd opened this issue Nov 29, 2023 · 3 comments · Fixed by #2799
Milestone

Comments

@0pdd
Copy link

0pdd commented Nov 29, 2023

The puzzle 2591-eade6066 from #2591 has to be resolved:

* @todo #2591:60min Make type casting when logging an app dataization result. The cast is
* necessary in this expression {@code new Dataized(app).take()} in order to correctly
* convert it to a string. This conversion it necessary for proper logging.

The puzzle was created by rultor on 29-Nov-23.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@maxonfjvipon
Copy link
Member

@levBagryansky maybe you can take it and make the same printing you did in #2772?

@levBagryansky
Copy link
Member

levBagryansky commented Jan 17, 2024

@yegor256
What do you think about overriding of Dataized.toString() method which would return multiple representations of byte array like in the following switch case: https://github.com/objectionary/eo/blob/master/eo-runtime/src/main/java/EOorg/EOeolang/EOerror.java#L148 ?
Or maybe it is better to create dedicated class?

@yegor256
Copy link
Member

yegor256 commented Jan 17, 2024

@levBagryansky I would create a separate class for this

levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
levBagryansky added a commit to levBagryansky/eo that referenced this issue Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants