2645 printing byte array #2799
Merged
2645 printing byte array #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon please check |
maxonfjvipon
suggested changes
Jan 18, 2024
| * | ||
| * @since 0.36 | ||
| */ | ||
| public final class ToStringVerbose implements Function<byte[], String> { |
There was a problem hiding this comment.
@levBagryansky I think we should use a noun for the name of the class. May be something like VerboseBytesAaString that would accept bytes in constructor and would have method toString?
There was a problem hiding this comment.
@maxonfjvipon made it Supplier
maxonfjvipon
suggested changes
Jan 18, 2024
|
|
||
| @Override | ||
| public String get() { | ||
| final Bytes bytes = new BytesOf(this.data); |
There was a problem hiding this comment.
@levBagryansky I can see that this variable is used only in case 8:, I think it would be better to move it there
|
|
||
| /** | ||
| * Makes a String from byte array that can represent bool, | ||
| * double, int or {@link String}. |
There was a problem hiding this comment.
@levBagryansky something is wrong with indentation here
|
@maxonfjvipon please check |
maxonfjvipon
approved these changes
Jan 18, 2024
|
@yegor256 please check |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2645
PR-Codex overview
This PR focuses on improving the readability and logging of error messages in the code.
Detailed summary
Main.javafile to log the app dataization result in a more readable format.VerboseBytesAsStringclass to convert byte arrays into a string representation.EOerror.javafile to use theVerboseBytesAsStringclass for error message logging.VerboseBytesAsStringclass.