Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hmethod-after-vmethod.yaml:1-4: Enable the test when it's... #2806

Closed
0pdd opened this issue Jan 22, 2024 · 5 comments · Fixed by #2908
Closed

hmethod-after-vmethod.yaml:1-4: Enable the test when it's... #2806

0pdd opened this issue Jan 22, 2024 · 5 comments · Fixed by #2908
Milestone

Comments

@0pdd
Copy link

0pdd commented Jan 22, 2024

The puzzle 2736-68649196 from #2736 has to be resolved:

# @todo #2736:30min Enable the test when it's possible. Such syntax is invalid - we can't use
# horizontal method after vertical method. If we decide that we allow such syntax we should add
# "vmethod" to "hmethodHeadExtended" rule and resolve left recursion violation. Don't forget
# to remove the puzzle

The puzzle was created by rultor on 22-Jan-24.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@maxonfjvipon
Copy link
Member

@yegor256 please take a look. Should we all horizontal method after vertical one?

x
.y.z

@maxonfjvipon maxonfjvipon added this to the Important milestone Feb 2, 2024
@yegor256
Copy link
Member

yegor256 commented Feb 3, 2024

@maxonfjvipon I believe, this syntax should be prohibited. We should either use horizontal or vertical syntax, not a mix of them.

@maxonfjvipon
Copy link
Member

@yegor256 ok, then I have a few more questions about syntax. What syntax should be valid, what should not:

  1. vertical method after vertical application
x
  y
.z
  1. vertical method after horizontal application
x y
.z
  1. vertical method after horizontal method
x.y
.z
  1. horizontal application after vertical method
x
.y z
  1. vertical application after vertical method
x
.y
  z

@maxonfjvipon
Copy link
Member

@yegor256 WDYT?

@yegor256
Copy link
Member

@maxonfjvipon I thinks (2) and (3) must be illegal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants