Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2280 universe find and dataize #2385

Merged
merged 12 commits into from
Aug 16, 2023

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Aug 13, 2023

Closes: #2384, #2280


PR-Codex overview

This PR focuses on implementing the "find" and "dataize" methods in the Universe class.

Detailed summary

  • Changed the access modifier of the DummyWithAtFree class to private.
  • Implemented the "find" method in the Universe class to find an object by its location.
  • Implemented the "dataize" method in the Universe class to dataize an object by its vertex.
  • Added a new private field "indexed" in the Universe class to store already found objects.
  • Added a new private method "replace" in the Universe class to replace specific EO symbols with Java symbols.
  • Added tests for the "find" and "dataize" methods in the UniverseTest class.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@Graur could you please review these changes?

Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky Good one!

eo-runtime/src/test/java/org/eolang/UniverseTest.java Outdated Show resolved Hide resolved
eo-runtime/src/test/java/org/eolang/UniverseTest.java Outdated Show resolved Hide resolved
Copy link
Contributor

@Graur Graur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky Good one
@yegor256 Please take a look

@levBagryansky
Copy link
Member Author

@yegor256 please check

@levBagryansky
Copy link
Member Author

@yegor256 please take a look

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 16, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b5a4c9a into objectionary:master Aug 16, 2023
11 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 16, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 12min)

@levBagryansky levBagryansky deleted the 2280_universe-find branch August 17, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universe.java:110-113: Implement the "dataize" method. It...
4 participants