-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1602): default empty versions near to the root object #2501
Closed
maxonfjvipon
wants to merge
19
commits into
objectionary:master
from
maxonfjvipon:feat/#1602/default-versions
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ae8fb3c
feat(#1602): default empty versions
maxonfjvipon b670d1f
feat(#1602): versions down
maxonfjvipon 801768b
feat(#1602): versioned
maxonfjvipon 1e784c5
feat(#1602): checkstyle
maxonfjvipon 2872a7d
feat(#1602): order
maxonfjvipon e111584
feat(#1602): right train
maxonfjvipon b757583
feat(#1602): pack
maxonfjvipon eb3a109
feat(#1602): endless
maxonfjvipon 7b0be79
feat(#1602): dots
maxonfjvipon bf24801
feat(#1602): dots x2
maxonfjvipon eee1b9f
feat(#1602): disable test
maxonfjvipon 48def2e
feat(#1602): refactor
maxonfjvipon e82ea28
Merge branch 'master' into feat/#1602/default-versions
maxonfjvipon 8917018
feat(#1602): versioned + comment
maxonfjvipon 43d9115
feat(#1602): todo
maxonfjvipon f9173e0
feat(#1602): typo
maxonfjvipon 4e8317b
feat(#1602): checkstyle
maxonfjvipon 395032b
feat(#1602): comments
maxonfjvipon 442d162
feat(#1602): docs
maxonfjvipon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon Could you please rename this method? It is hard to understand what you mean by this abbreviation. I don't think you meant this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo first "o" stands for "optional". Property that will be added depends on giving condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon Why do we need such a method, if in case of
condition==false
we can just avoid calling this method?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo this method is used 8 times in
XeListener
. We either calloprop
8 times or replace these calls withif (this.versioned) { this.objects.prop(key); }
at 8 placesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon I don't know how it happened that we have
xprop
method, but both of themxprop
andoprop
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volodya-lombrozo there's nothing about overloading
prop
- just adds property, usesattr
from Xemlbyxprop
- changes property by given xpath, usesxattr
from Xembly. It was added here: feat(#2399): new syntax ebnf #2474oprop
- addes property if given condition is TRUE. Actually is a temporary method. When object versioning is implemented it will be removed and all its occurrences will be replaced withprop