jhome introduced #2608
Merged
jhome introduced #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volodya-lombrozo pls, review |
| @@ -179,7 +180,7 @@ private static String run( | |||
| */ | |||
| private static void compileJava(final Path generated, final Path classes) { | |||
| new Jaxec( | |||
| SnippetTestCase.jdkExecutable("javac"), | |||
| new Jhome().path("bin/javac").toString(), | |||
There was a problem hiding this comment.
@yegor256 What do you think if we add javac() and java() methods to Jhome. Then, instead of new Jhome().path("bin/javac") we will need to write only new Jhome().javac()?
There was a problem hiding this comment.
@yegor256 Created a separate issue for that: yegor256/jhome#5
volodya-lombrozo
approved these changes
Nov 21, 2023
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2607
PR-Codex overview
Detailed summary
com.yegor256:jhome:0.0.1with test scope inpom.xml.com.yegor256.JhomeinMainTest.javaandSnippetTestCase.javato locate executable files insideJAVA_HOMEdirectory.