Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java() and javac() #5

Closed
volodya-lombrozo opened this issue Nov 21, 2023 · 7 comments · Fixed by #6
Closed

java() and javac() #5

volodya-lombrozo opened this issue Nov 21, 2023 · 7 comments · Fixed by #6
Assignees
@volodya-lombrozo
Labels
enhancement New feature or request

Comments

@volodya-lombrozo
Copy link
Contributor

What do you think if we add javac() and java() methods to Jhome? Then, instead of new Jhome().path("bin/javac") we will be able to write only new Jhome().javac().
@volodya-lombrozo volodya-lombrozo mentioned this issue Nov 21, 2023
Merged
@yegor256
Copy link
Owner

@volodya-lombrozo perfect idea! Do you have time to implement this?

@yegor256 yegor256 added the enhancement New feature or request label Nov 21, 2023
@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Yes, just assign it to me

volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 21, 2023
@volodya-lombrozo
feat(#5): implement java and javac methods for Jhome
2c83ee0
@volodya-lombrozo volodya-lombrozo mentioned this issue Nov 21, 2023
Merged
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 21, 2023
@volodya-lombrozo
feat(#5): add puzzle for javac method if we are running on JRE
c84d32d
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): update the branch
696d83f
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): update README
329edf7
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): refactor tests a bit
45c1d80
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): use path method instead of direct home usage
e29cf41
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): remove redundant methods
e12ae61
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): take care about binary extension
072d3c5
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): fix all qulice suggestions
45bbbaa
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): Add informative message if we can't find java in bin folder
2bb925a
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): Don't care about extensions
b5adbe8
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): fix all qulice suggestions
63e2719
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): allow to run workflows from UI
c081186
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): add debug branch
7177ebf
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): add log message for javac
68e7060
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): return extensions
7ddac0d
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): handle extension correctly
5b60a44
volodya-lombrozo referenced this issue in volodya-lombrozo/jhome Nov 22, 2023
@volodya-lombrozo
feat(#5): return the code in mvn workflow to the original state
2268a06
@rultor rultor closed this as completed in #6 Nov 22, 2023
@0pdd 0pdd mentioned this issue Nov 22, 2023
Closed
@0pdd
Copy link

0pdd commented Nov 22, 2023

@volodya-lombrozo the puzzle #10 is still not solved.

@yegor256
Copy link
Owner

@rultor release, tag is 0.0.3

@rultor
Copy link
Collaborator

rultor commented Nov 22, 2023

@rultor release, tag is 0.0.3

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Nov 22, 2023

@rultor release, tag is 0.0.3

@yegor256 Done! FYI, the full log is here (took me 5min)

@0pdd
Copy link

0pdd commented Dec 4, 2023

@volodya-lombrozo the only puzzle #10 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@volodya-lombrozo volodya-lombrozo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#5): Add java and javac methods to Jhome volodya-lombrozo/jhome
4 participants
@yegor256 @rultor @0pdd @volodya-lombrozo