fix(#2406): added test for FakeMaven #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yanich96 please add to the description of pull request:
Also it would be nice to change the header of the PR |
maxonfjvipon
suggested changes
Nov 30, 2023
| .execute(AssembleMojo.class) | ||
| .result(); | ||
| MatcherAssert.assertThat( | ||
| res, |
There was a problem hiding this comment.
@Yanich96 let's add assertion message here and below
There was a problem hiding this comment.
@maxonfjvipon I have done
| @@ -70,6 +70,13 @@ | |||
| * their behaviour and results. | |||
| * NOT thread-safe. | |||
| * @since 0.28.12 | |||
| * @todo #2406:30min Fix {@link FakeMaven#allowedParams(Class)} | |||
| * This function parameters of executed Mojo in {@link FakeMaven#execute(Class)} | |||
There was a problem hiding this comment.
@Yanich96 I think English needs to be corrected here. Please use translator or chatGPT
There was a problem hiding this comment.
@maxonfjvipon I have changed
Yanich96
changed the title
|
@yegor256 please approve |
1 similar comment
|
@yegor256 please approve |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2406
What's done:
PR-Codex overview
This PR focuses on fixing the configuration of custom parameters in the
FakeMavenclass.Detailed summary
FakeMaven#allowedParams(Class)function to configure parameters of executed Mojo and parameters of Mojos inside the executed Mojo.AssembleMojo.