-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#2713): check time in OptCached #2720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yegor256 Could you review this one, please? Does it solve the original problem? |
@rultor merge |
@volodya-lombrozo @yegor256 Oops, I failed. You can see the full log here (spent 21min)
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the time when XMIR was created and compare it with the time of a program crated in cache.
Closes: #2713.
History:
PR-Codex overview
This PR focuses on optimizing the caching mechanism in the
OptCached
class. It introduces methods to check if the cache contains a program and to retrieve the path to the cached program. Additionally, it adds logic to compare the creation time of the cached program with the time specified in the XML program.Detailed summary
cached
method to return the path to the cached programcontains
method to check if the cache contains the program