3148 chRemote #3149
Merged
3148 chRemote #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxonfjvipon please review. This test does not cover current vulnerability, however it protect us from thread-unsafety in future. |
| /** | ||
| * Hash of tag. | ||
| * | ||
| * @since 0.28.11 | ||
| */ | ||
| public interface CommitHash { | ||
| @FunctionalInterface |
There was a problem hiding this comment.
@levBagryansky why do we need it here?
There was a problem hiding this comment.
@maxonfjvipon I added it because this actually is a functional interface.
levBagryansky
commented
Apr 26, 2024
| /** | ||
| * Hash of tag. | ||
| * | ||
| * @since 0.28.11 | ||
| */ | ||
| public interface CommitHash { | ||
| @FunctionalInterface | ||
| public interface CommitHash extends Scalar<String> { |
There was a problem hiding this comment.
@maxonfjvipon I inhereted it firstly because it has the same method so it really can be inherited. Also it allowed to write
Stream.generate(
() -> new ChRemote("0.23.19")
).limit(threads).collect(Collectors.toList())and this is cool.
maxonfjvipon
approved these changes
Apr 27, 2024
|
@yegor256 please take a look |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3148
PR-Codex overview
The focus of this PR is to refactor the
CommitHashinterface to extendScalar<String>and make improvements to theChRemoteclass for better performance and thread safety.Detailed summary
CommitHashinterface now extendsScalar<String>ChRemoteChRemoteTestwith new test method