-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3148 chRemote #3149
Merged
Merged
3148 chRemote #3149
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
552d360
#3148: thread-safety vulnerability
levBagryansky 3f43650
#3058: violations
levBagryansky 9511317
Merge branch 'master' into 3148_chremore
levBagryansky 903580d
#3148: indentations
levBagryansky c0a5dca
#3148: unused import
levBagryansky File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,12 +23,15 @@ | |
*/ | ||
package org.eolang.maven.hash; | ||
|
||
import org.cactoos.Scalar; | ||
|
||
/** | ||
* Hash of tag. | ||
* | ||
* @since 0.28.11 | ||
*/ | ||
public interface CommitHash { | ||
@FunctionalInterface | ||
public interface CommitHash extends Scalar<String> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @maxonfjvipon I inhereted it firstly because it has the same method so it really can be inherited. Also it allowed to write Stream.generate(
() -> new ChRemote("0.23.19")
).limit(threads).collect(Collectors.toList()) and this is cool. |
||
|
||
/** | ||
* SHA Hash. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levBagryansky why do we need it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon I added it because this actually is a functional interface.