Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3294): added PhiMojo fails on error flag #3295

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Jul 29, 2024

Ref: #3294


PR-Codex overview

The focus of this PR is to introduce a new parameter phiFailOnError in PhiMojo to control error handling behavior.

Detailed summary

  • Added phiFailOnError parameter to PhiMojo class
  • Updated logic in PhiMojo to handle errors based on phiFailOnError value
  • Modified tests to cover error handling scenarios

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rultor merge

@volodya-lombrozo
Copy link
Member

@yegor256 Could you try to merge it one more time, please? It's quite urgent and blocks several issues.

@maxonfjvipon
Copy link
Member Author

@rultor status

@rultor
Copy link
Contributor

rultor commented Jul 29, 2024

@rultor status

@maxonfjvipon This is what's going on here:

  • no new requests registered
  • build is not running

More information about Rultor commands you can get here.

@yegor256 yegor256 merged commit f565073 into objectionary:master Jul 29, 2024
22 checks passed
@yegor256
Copy link
Member

@maxonfjvipon merged

@0crat
Copy link

0crat commented Jul 29, 2024

@yegor256 Thanks for the review! You've earned +38 points for this: +25 as a basis; +23 for the 235 hits-of-code that you reviewed; -10 for too few (1) comments. Your running balance is +157.

@0crat
Copy link

0crat commented Jul 29, 2024

@maxonfjvipon Thanks for the contribution! You've earned +13 points for this: +30 as a basis; -7 for too many hits-of-code (235 >= 100); -10 for too few (4) comments. Please, keep them coming. Your running balance is +180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants