Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): socket syscall #3369

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Sep 13, 2024

Ref: #3251


PR-Codex overview

This PR introduces socket-related enhancements for POSIX and Win32 systems, including new functions for socket creation and cleanup.

Detailed summary

  • Added socket syscall for POSIX and Win32
  • Added close syscall for POSIX
  • Implemented WSACleanup function call for Win32

The following files were skipped due to too many changes: eo-runtime/src/main/java/EOorg/EOeolang/EOsys/Win32/ClosesocketFuncCall.java, eo-runtime/src/main/java/EOorg/EOeolang/EOsys/Win32/SocketFuncCall.java, eo-runtime/src/test/java/EOorg/EOeolang/EOsys/EOwin32Test.java, eo-runtime/src/main/java/EOorg/EOeolang/EOsys/Win32/WSAStartupFuncCall.java, eo-runtime/src/main/java/EOorg/EOeolang/EOsys/Win32/Winsock.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon thanks!

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 13, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f12004e into objectionary:master Sep 13, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented Sep 13, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 32min)

@0crat
Copy link

0crat commented Sep 13, 2024

@yegor256 Hey there! Thanks for your review of the 753 hits-of-code. As per our policy, you've earned +4 points as a base reward. We appreciate your effort, but noticed only 3 comments were made during the review. This resulted in a 10-point deduction, as our policy encourages more substantial feedback. Your final reward is +4 points (the minimum allowed). Keep up the good work and remember to provide more detailed comments in future reviews. Your current balance stands at -60. 👍

@0crat
Copy link

0crat commented Sep 13, 2024

@maxonfjvipon Thank you for your contribution! Your effort is appreciated, but there are a few areas for improvement. You've earned +4 points: +4 base, -8 for exceeding 200 hits-of-code (753), -4 for insufficient comments (3), and +12 adjusted to meet the minimum. Remember, quality over quantity is key. Please aim for more concise contributions with thorough code reviews in the future. Your current balance stands at +28. Keep up the good work and continue to refine your approach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants