Bump default chrome docker version

oblador · Nov 2, 2023 · d98e8a2 · d98e8a2
1 parent 3ab5f6d
commit d98e8a2
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 1,545 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -2,8 +2,6 @@ name: Tests
 
 on:
   push:
-    branches:
-      - master
   pull_request:
     branches:
       - master
@@ -23,9 +21,9 @@ jobs:
       - name: Install dependencies
         run: yarn --frozen-lockfile --non-interactive --silent --ignore-scripts
       - name: Prepare docker
-        run: docker pull yukinying/chrome-headless-browser-stable:100.0.4896.127
+        run: docker pull yukinying/chrome-headless-browser-stable:118.0.5993.117
       - name: Run unit tests
-        run: yarn test-ci
+        run: DEBUG=loki:* yarn test-ci
 
   static-analysis:
     name: Static analysis

diff --git a/docs/command-line-arguments.md b/docs/command-line-arguments.md
@@ -29,8 +29,8 @@ yarn loki test -- --port 9009
 | **`--chromeAwsLambdaFunctionName`**     | Name of the use to capture screenshots.                                                                                                         | `loki`                                                    |
 | **`--chromeAwsLambdaRetries`**          | The number of retries for invoking the lambda, in case of failure.                                                                              | `0`                                                       |
 | **`--chromeConcurrency`**               | How many stories to test in parallel when using chrome                                                                                          | `4`                                                       |
-| **`--chromeDockerImage`**               | What docker image to use when running chrome                                                                                                    | `yukinying/chrome-headless-browser-stable:100.0.4896.127` |
-| **`--chromeDockerWithoutSeccomp`**      | Run chrome docker without custom seccomp settings.                                                                                              | `false`                                                   |
+| **`--chromeDockerImage`**               | What docker image to use when running chrome                                                                                                    | `yukinying/chrome-headless-browser-stable:118.0.5993.117` |
+| **`--chromeDockerWithoutSeccomp`**      | Run chrome docker without unconfined seccomp settings.                                                                                          | `false`                                                   |
 | **`--chromeDockerUseCopy`**             | Use docker copy instead of volume mount for local stories                                                                                       | `false`                                                   |
 | **`--chromeEnableAnimations`**          | Enable CSS transitions and animations.                                                                                                          | `false`                                                   |
 | **`--chromeFlags`**                     | Custom chrome flags.                                                                                                                            | `--headless --disable-gpu --hide-scrollbars`              |

diff --git a/packages/runner/src/commands/test/default-options.json b/packages/runner/src/commands/test/default-options.json
@@ -4,7 +4,7 @@
   "chromeAwsLambdaBatchSize": "1",
   "chromeAwsLambdaBatchConcurrency": "1",
   "chromeConcurrency": "4",
-  "chromeDockerImage": "yukinying/chrome-headless-browser-stable:100.0.4896.127",
+  "chromeDockerImage": "yukinying/chrome-headless-browser-stable:118.0.5993.117",
   "chromeFlags": "--headless --disable-gpu --hide-scrollbars",
   "chromeLoadTimeout": "60000",
   "chromeRetries": "0",

diff --git a/packages/target-chrome-docker/src/create-chrome-docker-target.js b/packages/target-chrome-docker/src/create-chrome-docker-target.js
@@ -43,7 +43,7 @@ const waitOnCDPAvailable = (host, port) =>
 
 function createChromeDockerTarget({
   baseUrl = 'http://localhost:6006',
-  chromeDockerImage = 'yukinying/chrome-headless-browser-stable:100.0.4896.127',
+  chromeDockerImage = 'yukinying/chrome-headless-browser-stable:118.0.5993.117',
   chromeFlags = ['--headless', '--disable-gpu', '--hide-scrollbars'],
   dockerNet = null,
   dockerWithSudo = false,
@@ -62,7 +62,7 @@ function createChromeDockerTarget({
   const execute = getExecutor(dockerWithSudo);
 
   if (!chromeDockerWithoutSeccomp) {
-    runArgs.push(`--security-opt=seccomp=${__dirname}/docker-seccomp.json`);
+    runArgs.push('--security-opt=seccomp=unconfined');
   }
   runArgs.push('--add-host=host.docker.internal:host-gateway');
 
@@ -146,7 +146,10 @@ function createChromeDockerTarget({
       const logs = execute(dockerPath, ['logs', dockerId, '--follow']);
       const errorLogs = [];
       logs.stderr.on('data', (chunk) => {
-        errorLogs.push(chunk);
+        console.error(chunk.toString('utf8'));
+      });
+      logs.stdout.on('data', (chunk) => {
+        console.log(chunk.toString('utf8'));
       });
 
       host = await getNetworkHost(execute, dockerId);