allow user to use docker cp instead of volume mount, fix #9 #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techeverri mind take a look at this when you're free :) ? |
|
Hey @missing1984 |
oblador
reviewed
Nov 24, 2020
oblador
reviewed
Nov 24, 2020
packages/target-chrome-docker/src/create-chrome-docker-target.js
Outdated
Show resolved
Hide resolved
oblador
reviewed
Nov 24, 2020
Co-authored-by: Joel Arvidsson <joel@oblador.se>
Co-authored-by: Joel Arvidsson <joel@oblador.se>
oblador
reviewed
Nov 26, 2020
Co-authored-by: Joel Arvidsson <joel@oblador.se>
oblador
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This should fix one of the long live issues. #9
Docker volume mount does not always work especially in a CI environment that often implemented as docker in docker.
Solution
Introduce a new flag
chromeDockerUseCopythat switches to use docker cp which is guaranteed to work in CI. Users can opt-in to this new behavior.I also fixed a couple of dependencies issues in this MR.