use setUserAuthenticationParameters for android >= 11 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
固定 |
androideveloper
approved these changes
Feb 14, 2024
renovate bot
added a commit
to valora-inc/wallet
that referenced
this pull request
Feb 21, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-keychain](https://togithub.com/oblador/react-native-keychain) | [`^8.1.2` -> `^8.1.3`](https://renovatebot.com/diffs/npm/react-native-keychain/8.1.2/8.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oblador/react-native-keychain (react-native-keychain)</summary> ### [`v8.1.3`](https://togithub.com/oblador/react-native-keychain/releases/tag/v8.1.3) [Compare Source](https://togithub.com/oblador/react-native-keychain/compare/v8.1.2...v8.1.3) #### What's Changed - use setUserAuthenticationParameters for android >= 11 by [@​AntoineThibi](https://togithub.com/AntoineThibi) in [oblador/react-native-keychain#613 - \[Fix]\[Android] Bugfix for lambda functions not workin in older projects. by [@​sohail-shrestha](https://togithub.com/sohail-shrestha) in [oblador/react-native-keychain#585 - \[Fix]\[Android] Unsupported RSA key size for StrongBox by [@​frw](https://togithub.com/frw) in [oblador/react-native-keychain#577 #### New Contributors - [@​AntoineThibi](https://togithub.com/AntoineThibi) made their first contribution in [oblador/react-native-keychain#613 - [@​sohail-shrestha](https://togithub.com/sohail-shrestha) made their first contribution in [oblador/react-native-keychain#585 - [@​frw](https://togithub.com/frw) made their first contribution in [oblador/react-native-keychain#577 **Full Changelog**: oblador/react-native-keychain@v8.1.2...v8.1.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
](https://renovatebot.com){kind=link}
|
This seems to be causing issues on Android, where start times are up by 8-20 seconds and even sometimes cause ANRs , see #630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Android >= 11 to force the use of biometry if required : an attacker could bypass the use of biometry by unlocking the device with the pin and then could access the keychain, even though we would like it to be protected with the biometry.
Fix coming from a comment on this PR : #592
It should solve for Android >=11 the issues :
However, it does not solve the issue for Android < 11 due to the way the keychain is implemented on Android.