Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with monorepo info for Android #1476

Merged
merged 2 commits into from Jul 17, 2023
Merged

Update README with monorepo info for Android #1476

merged 2 commits into from Jul 17, 2023

Conversation

samzmann
Copy link
Contributor

@samzmann samzmann commented Dec 22, 2022

Just spent a few hours trying to understand why my icons where not showing on Android after changing to a monorepo.

This issue #1183 requests that the docs be updated to mention the extra config necessary for RNVI to work well in a monorepo.

This PR addresses exactly this.

fixes: #1183
fixes: #1117

Please let me know if anything is unclear or inaccurate.

✌️

@oblador oblador merged commit 6e48dbd into oblador:master Jul 17, 2023
hyochan pushed a commit to dooboolab-community/dooboo-ui that referenced this pull request Jul 17, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-native-vector-icons](https://togithub.com/oblador/react-native-vector-icons)
| [`^9.2.0` ->
`^10.0.0`](https://renovatebot.com/diffs/npm/react-native-vector-icons/9.2.0/10.0.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-vector-icons/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-vector-icons/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-vector-icons/9.2.0/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-vector-icons/9.2.0/10.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>oblador/react-native-vector-icons
(react-native-vector-icons)</summary>

###
[`v10.0.0`](https://togithub.com/oblador/react-native-vector-icons/releases/tag/v10.0.0):
10.0.0

[Compare
Source](https://togithub.com/oblador/react-native-vector-icons/compare/v9.2.0...v10.0.0)

#### Overview

-   Improved support for React Native 0.72, 0.73 and RN Web.
-   New and updated icon sets.

#### Detailed Changes

- Fix link to FontAwesome website by
[@&#8203;nidelson](https://togithub.com/nidelson) in
[oblador/react-native-vector-icons#1444
- Upgrade example to React Native 0.70 by
[@&#8203;oblador](https://togithub.com/oblador) in
[oblador/react-native-vector-icons#1467
- Migrate to new architecture by
[@&#8203;oblador](https://togithub.com/oblador) in
[oblador/react-native-vector-icons#1468
- Remove setNativeProps by
[@&#8203;oblador](https://togithub.com/oblador) in
[oblador/react-native-vector-icons#1469
- Upgrade example to React Native 0.72 by
[@&#8203;oblador](https://togithub.com/oblador) in
[oblador/react-native-vector-icons#1517
- fix: make `lintVitalAnalyze*` depend on copy by
[@&#8203;msbit](https://togithub.com/msbit) in
[oblador/react-native-vector-icons#1515
- Update README.md by
[@&#8203;aniketjha9179](https://togithub.com/aniketjha9179) in
[oblador/react-native-vector-icons#1502
- Update README.md by [@&#8203;DaduDev](https://togithub.com/DaduDev) in
[oblador/react-native-vector-icons#1504
- Fix to get working with react-native-web by
[@&#8203;johnf](https://togithub.com/johnf) in
[oblador/react-native-vector-icons#1492
- RN-0.73 change Android configs for RN 0.73 compatibility by
[@&#8203;felipemillhouse](https://togithub.com/felipemillhouse) in
[oblador/react-native-vector-icons#1507
- Replace tabBarOptions with screenOptions by
[@&#8203;MenaiAla](https://togithub.com/MenaiAla) in
[oblador/react-native-vector-icons#1478
- fix (ios): support kCTFontManagerErrorDuplicatedName as allowable
error by [@&#8203;iBotPeaches](https://togithub.com/iBotPeaches) in
[oblador/react-native-vector-icons#1474
- Update README with monorepo info for Android by
[@&#8203;samzmann](https://togithub.com/samzmann) in
[oblador/react-native-vector-icons#1476
- Improve Error Logging for Font Imports by
[@&#8203;JKeddo95](https://togithub.com/JKeddo95) in
[oblador/react-native-vector-icons#1475
- Update Ionicons to v7.1.0 by
[@&#8203;mrkpatchaa](https://togithub.com/mrkpatchaa) in
[oblador/react-native-vector-icons#1484
- Fontawesome6 (Closes
[#&#8203;1408](https://togithub.com/oblador/react-native-vector-icons/issues/1408))
by [@&#8203;johnf](https://togithub.com/johnf) in
[oblador/react-native-vector-icons#1483
- Use Node 16 in CI by [@&#8203;oblador](https://togithub.com/oblador)
in
[oblador/react-native-vector-icons#1518
- Upgrade Material Icons to Sept 2022 update by
[@&#8203;oblador](https://togithub.com/oblador) in
[oblador/react-native-vector-icons#1519
- Move ionicon build dependencies to devDependencies by
[@&#8203;oblador](https://togithub.com/oblador) in
[oblador/react-native-vector-icons#1520

#### New Contributors

- [@&#8203;nidelson](https://togithub.com/nidelson) made their first
contribution in
[oblador/react-native-vector-icons#1444
- [@&#8203;msbit](https://togithub.com/msbit) made their first
contribution in
[oblador/react-native-vector-icons#1515
- [@&#8203;aniketjha9179](https://togithub.com/aniketjha9179) made their
first contribution in
[oblador/react-native-vector-icons#1502
- [@&#8203;DaduDev](https://togithub.com/DaduDev) made their first
contribution in
[oblador/react-native-vector-icons#1504
- [@&#8203;johnf](https://togithub.com/johnf) made their first
contribution in
[oblador/react-native-vector-icons#1492
- [@&#8203;felipemillhouse](https://togithub.com/felipemillhouse) made
their first contribution in
[oblador/react-native-vector-icons#1507
- [@&#8203;MenaiAla](https://togithub.com/MenaiAla) made their first
contribution in
[oblador/react-native-vector-icons#1478
- [@&#8203;iBotPeaches](https://togithub.com/iBotPeaches) made their
first contribution in
[oblador/react-native-vector-icons#1474
- [@&#8203;samzmann](https://togithub.com/samzmann) made their first
contribution in
[oblador/react-native-vector-icons#1476
- [@&#8203;JKeddo95](https://togithub.com/JKeddo95) made their first
contribution in
[oblador/react-native-vector-icons#1475
- [@&#8203;mrkpatchaa](https://togithub.com/mrkpatchaa) made their first
contribution in
[oblador/react-native-vector-icons#1484

**Full Changelog**:
oblador/react-native-vector-icons@v9.2.0...v10.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/dooboolab-community/dooboo-ui).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44LjExIiwidXBkYXRlZEluVmVyIjoiMzYuOC4xMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add monorepo documentation for specifying iconFontsDir cannot load icons in android
3 participants