Using SDK Version variables from root project #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of assuming the `compileSdkVersion`, `targetSdkVersion`, etc, read it from the root project. Default `compileSdkVersion` and `targetSdkVersion` to the latest versions. Android Target API Level 26 will be required in August 2018. https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html And the React Native team is already working on this: facebook/react-native#17741 facebook/react-native#18095
|
Thanks! Would you mind documenting this too? |
oblador
reviewed
May 30, 2018
android/build.gradle
Outdated
| @@ -10,13 +10,21 @@ buildscript { | |||
|
|
|||
| apply plugin: 'com.android.library' | |||
|
|
|||
| def _ext = rootProject.ext | |||
There was a problem hiding this comment.
Why the _ prefix for all variables, can you rename the variables to something more sensible?
oblador
reviewed
May 30, 2018
android/build.gradle
Outdated
| @@ -10,13 +10,21 @@ buildscript { | |||
|
|
|||
| apply plugin: 'com.android.library' | |||
|
|
|||
| def _ext = rootProject.ext | |||
|
|
|||
| def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+' | |||
There was a problem hiding this comment.
Wouldn't it make sense to have the setting be named reactNativeVersion for consistency?
|
It works well, maybe you should use implementation instead of compile to avoid the deprecated warning. |
oblador
approved these changes
Jul 20, 2018
|
I came here to also fork and make a PR for this. Thanks for beating me to it! Can we get a new release, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assuming the
compileSdkVersion,targetSdkVersion, etc, read it from the root project.Default
compileSdkVersionandtargetSdkVersionto the latest versions.Android Target API Level 26 will be required in August 2018.
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html
And the React Native team is already working on this:
facebook/react-native#17741
facebook/react-native#18095