Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using SDK Version variables from root project #714

Merged
merged 3 commits into from
Jul 20, 2018
Merged

Using SDK Version variables from root project #714

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a4ed5a
Using SDK Version variables from root project
rayronvictor Apr 24, 2018
baaabc1
Renaming variables for consistency
rayronvictor Jun 5, 2018
0a91292
Rename variables and use *Version for all settings
oblador Jul 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,21 @@ buildscript {

apply plugin: 'com.android.library'

def ext = rootProject.ext

def projectReactNativeVersion = ext.has('reactNativeVersion') ? ext.reactNativeVersion : '+'
def projectCompileSdkVersion = ext.has('compileSdkVersion') ? ext.compileSdkVersion : 27
def projectBuildToolsVersion = ext.has('buildToolsVersion') ? ext.buildToolsVersion : '27.0.3'
def projectMinSdkVersion = ext.has('minSdkVersion') ? ext.minSdkVersion : 16
def projectTargetSdkVersion = ext.has('targetSdkVersion') ? ext.targetSdkVersion : 27

android {
compileSdkVersion 26
buildToolsVersion "26.0.1"
compileSdkVersion projectCompileSdkVersion
buildToolsVersion projectBuildToolsVersion

defaultConfig {
minSdkVersion 16
targetSdkVersion 26
minSdkVersion projectMinSdkVersion
targetSdkVersion projectTargetSdkVersion
versionCode 1
versionName "1.0"
}
Expand All @@ -30,5 +38,5 @@ repositories {
}

dependencies {
compile "com.facebook.react:react-native:+"
compile "com.facebook.react:react-native:${projectReactNativeVersion}"
}