Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add subtypes of medium spiny neurons #1752

Merged
merged 12 commits into from
Dec 14, 2022
Merged

add subtypes of medium spiny neurons #1752

merged 12 commits into from
Dec 14, 2022

Conversation

shawntanzk
Copy link
Contributor

#gogoeditdiff
fixes #1744
Not too sure about eSPN -> might belong in PCL instead, thoughts @dosumis?

#gogoeditdiff
fixes #1744
Not too sure about eSPN -> might belong in PCL instead, thoughts @dosumis?
@shawntanzk shawntanzk self-assigned this Nov 30, 2022
@github-actions
Copy link

github-actions bot commented Nov 30, 2022

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-12-14/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2022-12-14/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4023026 http://purl.obolibrary.org/obo/CL_4023026

Added

CL_4023029 http://purl.obolibrary.org/obo/CL_4023029

Added

@github-actions
Copy link

github-actions bot commented Nov 30, 2022

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4023026 http://purl.obolibrary.org/obo/CL_4023026

Added

CL_4023029 http://purl.obolibrary.org/obo/CL_4023029

Added

@dosumis
Copy link
Contributor

dosumis commented Nov 30, 2022

Not too sure about eSPN -> might belong in PCL instead, thoughts @dosumis?

Agree if only distinction is gene expression. In PCL should have taxon constraint. Ideally would have a bag of markers too. Is is possible to curate this from paper?

@shawntanzk
Copy link
Contributor Author

In PCL should have taxon constraint. Ideally would have a bag of markers too. Is is possible to curate this from paper?

I can put a rodent taxon constraint, and there are markers, but its a pretty big bag so representing all of them might be unwieldy. However, the major concern with that the reason we are adding the term (or at least the reason why its on our radar) is that a cell in adult human brain is annotated as eSPN, so we still need a grouping term regardless.

@shawntanzk
Copy link
Contributor Author

opened ticket for eccentric medium spiny neuron in PCL and removed it from here, ready for review

@shawntanzk shawntanzk requested a review from a user December 8, 2022 14:18
@shawntanzk shawntanzk marked this pull request as ready for review December 8, 2022 14:18
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
@shawntanzk shawntanzk requested a review from a user December 9, 2022 11:49
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.
A quick online search reveals several papers describing direct and indirect pathway spiny neurones, so may want to consult and reference those instead of wikipedia.

To also consider: describing these cell types as D1+ MSNs or D2+ MSNs may actually get to what is really differentiating these cell type phenotypes instead of relying solely on location.

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
@shawntanzk
Copy link
Contributor Author

To also consider: describing these cell types as D1+ MSNs or D2+ MSNs may actually get to what is really differentiating these cell type phenotypes instead of relying solely on location.

Traditionally yes, but with new transcriptomics stuff, eccentric MSN kindda messes that up. I think it is accurate to have them as exact synonyms and to add that into definitions.

@shawntanzk shawntanzk requested a review from a user December 13, 2022 08:38
AnnotationAssertion(<http://purl.org/dc/terms/contributor> obo:CL_4023026 <https://orcid.org/0000-0001-7258-9596>)
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:34727523"^^xsd:string) Annotation(oboInOwl:hasSynonymType <http://purl.obolibrary.org/obo/cl#abbreviation>) oboInOwl:hasExactSynonym obo:CL_4023026 "D2-MSN")
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:30096299"^^xsd:string) Annotation(oboInOwl:hasSynonymType <http://purl.obolibrary.org/obo/cl#abbreviation>) oboInOwl:hasExactSynonym obo:CL_4023026 "dSPN"^^xsd:string)
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:34727523"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4023026 "dopamine 2 medium spiny neuron")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a synonym for indirect pathway MSN.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually do not see this synonym in the dbxref.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its spelling out the short form that they used - my thinking being that some people might search using full name and all

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this synonym (in a spelled out form) does not appear in the reference, consider removing it and/or the dbxref. If a user searches "dopamine 1 medium spiny neuron", the class will still appear in Protégé without this synonym present.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, ill remove the dbxref. I'd still rather keep the synonym in as I think it is useful.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@shawntanzk shawntanzk requested a review from a user December 14, 2022 09:08
AnnotationAssertion(Annotation(oboInOwl:hasDbXref "PMID:34727523"^^xsd:string) oboInOwl:hasExactSynonym obo:CL_4023026 "dopamine 1 medium spiny neuron")
AnnotationAssertion(rdfs:label obo:CL_4023026 "direct pathway medium spiny neuron")
SubClassOf(obo:CL_4023026 obo:CL_1001474)
SubClassOf(obo:CL_4023026 ObjectSomeValuesFrom(obo:RO_0002292 obo:PR_000001175))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be an upstream modelling issue, but is there evidence D1A receptors are expressed (versus any D1 receptor)? Uberon shows D1 receptor and D1A receptors as exact synonyms... unsure if that is accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is accurate according to PR ontology definition (translation of DRD1) where it is imported from - DRD1 encodes for dopamine 1 receptors. I think the modelling is right as it groups D1-like together (which includes DRD5). Took me a second look when I was adding that too and I studied dopamine receptors for my PhD >.< 2 years and everything is forgotten lol

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking issues found, but some concerns noted in comments.

@shawntanzk shawntanzk merged commit d07d8c6 into master Dec 14, 2022
@shawntanzk shawntanzk deleted the issue-1744 branch December 14, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] subtypes of medium spiny neurons
2 participants