Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #1892 NTR for respiratory new terms #1896

Merged
merged 8 commits into from
Mar 20, 2023
Merged

Conversation

aleixpuigb
Copy link
Collaborator

Addresses #1892 NTR for respiratory new terms

Addresses #1892 NTR for respiratory new terms
@aleixpuigb aleixpuigb self-assigned this Mar 16, 2023
@aleixpuigb aleixpuigb linked an issue Mar 16, 2023 that may be closed by this pull request
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@aleixpuigb aleixpuigb requested a review from a user March 17, 2023 10:07
@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-03-17/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2023-03-17/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

CL_4033016 http://purl.obolibrary.org/obo/CL_4033016

Added

CL_4033017 http://purl.obolibrary.org/obo/CL_4033017

Added

CL_4033018 http://purl.obolibrary.org/obo/CL_4033018

Added

CL_4033019 http://purl.obolibrary.org/obo/CL_4033019

Added

CL_4033020 http://purl.obolibrary.org/obo/CL_4033020

Added

CL_4033021 http://purl.obolibrary.org/obo/CL_4033021

Added

CL_4033022 http://purl.obolibrary.org/obo/CL_4033022

Added

CL_4033023 http://purl.obolibrary.org/obo/CL_4033023

Added

CL_4033024 http://purl.obolibrary.org/obo/CL_4033024

Added

CL_4033025 http://purl.obolibrary.org/obo/CL_4033025

Added

CL_4033026 http://purl.obolibrary.org/obo/CL_4033026

Added

fasciculates with http://purl.obolibrary.org/obo/RO_0002101

Removed

  • fasciculates with definition "Relation between a neuron and the neuron projection bundle it fasciculates with. FOL: x fasciculates_with y iff: exists some 'neuron ; CL_0000540'(x), some 'neuron projection bundle ; CARO_0001001'(y), some 'neuron projection ; GO_0043005'(np), np part_of x AND np overlaps y AND np aligned_with y"

Added

  • fasciculates with definition "Relation between a neuron and the neuron projection bundle it fasciculates with. FOL: x fasciculates_with y iff: exists some 'neuron ; CL_0000540'(x), some 'neuron projection bundle ; CARO_0001001'(y), some 'neuron projection ; GO_0043005'(np), np part_of x AND np overlaps y AND np aligned_with y"

has soma location http://purl.obolibrary.org/obo/RO_0002100

Removed

Added

has synaptic terminal in http://purl.obolibrary.org/obo/RO_0002130

Removed

Added

innervates http://purl.obolibrary.org/obo/RO_0002134

Removed

  • innervates definition "Relation between a 'neuron projection bundle' and a region in which one or more of its component neuron projections either synapses to targets or receives synaptic input. T innervates some R Expands_to: T has_fasciculating_neuron_projection that synapse_in some R."

Added

  • innervates definition "Relation between a 'neuron projection bundle' and a region in which one or more of its component neuron projections either synapses to targets or receives synaptic input. T innervates some R Expands_to: T has_fasciculating_neuron_projection that synapse_in some R."

synapsed by http://purl.obolibrary.org/obo/RO_0002103

Removed

Added

synapsed to http://purl.obolibrary.org/obo/RO_0002120

Removed

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

CL_4033016 http://purl.obolibrary.org/obo/CL_4033016

Added

CL_4033017 http://purl.obolibrary.org/obo/CL_4033017

Added

CL_4033018 http://purl.obolibrary.org/obo/CL_4033018

Added

CL_4033019 http://purl.obolibrary.org/obo/CL_4033019

Added

CL_4033020 http://purl.obolibrary.org/obo/CL_4033020

Added

CL_4033021 http://purl.obolibrary.org/obo/CL_4033021

Added

CL_4033022 http://purl.obolibrary.org/obo/CL_4033022

Added

CL_4033023 http://purl.obolibrary.org/obo/CL_4033023

Added

CL_4033024 http://purl.obolibrary.org/obo/CL_4033024

Added

CL_4033025 http://purl.obolibrary.org/obo/CL_4033025

Added

CL_4033026 http://purl.obolibrary.org/obo/CL_4033026

Added

GCIs

Added

inner chondrogenic layer of perichondrium http://purl.obolibrary.org/obo/UBERON_0008304

Added

outer fibrous layer of perichondrium http://purl.obolibrary.org/obo/UBERON_0008305

Added

perichondrium http://purl.obolibrary.org/obo/UBERON_0002222

Added

src/ontology/cl-edit.owl Outdated Show resolved Hide resolved
AnnotationAssertion(rdfs:label obo:CL_4033025 "perichondrial fibroblast")
EquivalentClasses(obo:CL_4033025 ObjectIntersectionOf(obo:CL_0000057 ObjectSomeValuesFrom(obo:BFO_0000050 obo:UBERON_0008305)))

# Class: obo:CL_4033026 (lung perichondrial fibroblast)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if there is a specific reason "lung" is used here and "airway" used in other terms. Ref describes "PC-fibro around the airway cartilage".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment, @bvarner-ebi. Initially I was considering airway for this same reason, however in the text you are quoting it is describing the localisation of PC-fibro in an image showing an airway. That doesn't exclude that it is also present in other pulmonary parts, as this cell is "enriched in the airways", but that doesn't mean it is exclusive, as cartilage it is not exclusive around the airways: "Cartilage (hyaline type) has the function of maintaining airway patency and it also serves for the attachment of local muscle and connective tissue."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this cell type does exist in lung tissue, would you please add that reference to the term. The quote mentioned above refers to the airways as well.

Copy link
Collaborator Author

@aleixpuigb aleixpuigb Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the scRNA-seq data, the majority of cells identified as PC-fibro came from airway tissue, but a small proportion (~0'4%) was found in parenchymal tissue:
image
Of course the number of cells is very small and they can be false positives (in the umap they don't map with the PC-fibro cluster) or a different kind of perichondrial cells. In the later case, it makes more sense to use 'lung perichondrial fibroblast' to encompass all PC-fibro found in the lung.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is from the dbxref, and if Par stands for parenchyma, it seems reasonable.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@aleixpuigb
Copy link
Collaborator Author

See inline comments.

Thank you for all your comments , @bvarner-ebi.

This commit removes 'serous secreting cell of trachea gland' as this cell type is already present in the ontology
@aleixpuigb aleixpuigb requested a review from a user March 20, 2023 11:41
@aleixpuigb
Copy link
Collaborator Author

'serous secreting cell of trachea gland' will no longer be a new term as this cell type exists as CL:1000330 "serous cell of epithelium of trachea". All serous cells in airways are found in submucosal gland. Therefore, a separate ticket will be issued to update names, textual definitions and logical definitions for serous cells.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleixpuigb
Copy link
Collaborator Author

Appears to be one pending grammar change.

Thank you, @bvarner-ebi. I was waiting to see if there were more edits to do everything together.

@aleixpuigb aleixpuigb merged commit 742f00d into master Mar 20, 2023
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@github-actions
Copy link

Your branch is 16 commit/s behind, please update your branch.

@anitacaron anitacaron deleted the 1892_NTR_lung branch September 29, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] Respiratory new cell types
1 participant