Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please revise UBERON:0001850 lacrimal drainage system #2225

Closed
paola-scibite opened this issue Dec 21, 2021 · 10 comments · Fixed by #3119
Closed

Please revise UBERON:0001850 lacrimal drainage system #2225

paola-scibite opened this issue Dec 21, 2021 · 10 comments · Fixed by #3119

Comments

@paola-scibite
Copy link

UBERON:0001850 lacrimal drainage system
has an editor note "TODO - resolve lacrimal canaliculus vs larcimal duct"
please see obophenotype/cell-ontology#1392 for implications/consequences in CL too. Thanks!

@paolaroncaglia
Copy link
Contributor

Dear Uberon and CL editors,
No rush, but it'd be great if someone other than me could address this issue please, along with the related CL one. (I'll assign to myself for now so it doesn't get lost, but feel free to unassign!)
Note that UBERON:0001850 'lacrimal drainage system' is applicable (restricted) to Tetrapoda, so the related anatomical terms should accommodate some non-mammalian vertebrates too. Thanks.

@paolaroncaglia paolaroncaglia self-assigned this Dec 21, 2021
@paolaroncaglia paolaroncaglia removed their assignment Feb 24, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

This issue has not seen any activity in the past 6 months; it will be closed automatically in one year from now if no action is taken.

@github-actions github-actions bot added the Stale label Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This issue has been closed automatically because it has not been updated in 18 months. Please re-open if you still need this to be addressed.

@github-actions github-actions bot added the autoclosed-unfixed This issue has been closed automatically. label Sep 2, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2023
@anitacaron anitacaron reopened this Sep 4, 2023
@anitacaron
Copy link
Collaborator

@bvarner-ebi, could you have a look into this, please? 😄

@anitacaron anitacaron assigned ghost Sep 4, 2023
@github-actions github-actions bot removed autoclosed-unfixed This issue has been closed automatically. Stale labels Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

Below are some notes and proposed edits.
CC @cmungall who is a dbxref for the text definitions of some of the terms noted below.

Synonyms

Definitions

  • CL:1000433 'epithelial cell of lacrimal canaliculus'
    
Equivalent to
 epithelial cell and part of some lacrimal canaliculus
    Agree, no change.

  • CL:1000435 'epithelial cell of lacrimal duct'
    
Equivalent to 
non-branched duct epithelial cell and part of some lacrimal drainage system
    Proposed changes:

    
- [x] Relabel 'epithelial cell of lacrimal duct' to 'epithelial cell of lacrimal drainage system'
    
- [x] Add "epithelial cell of lacrimal duct” (the current label) as a related synonym.
    
- [x] Change logical defintion to:
    
Equivalent to
 ‘duct epithelial cell’ and part of some 'lacrimal drainage system'
    
- [x] Update text def:
    
CURRENT: "An epithelial cell that is part of the lacrimal duct."
    
PROPOSED: "An epithelial cell that is part of the lacrimal drainage system."

Miscellaneous

  • Remove editor note from 'lacrimal drainage system' and 'lacrimal canaliculus'

  • Consider obsoleting the following and move current classes under 'duct epithelial cell':

branched duct epithelial cell
non-branched duct epithelial cell

  • Consider adding new Uberon term 'excretory lacrimal duct'

@dosumis
Copy link
Contributor

dosumis commented Oct 19, 2023

@paola-scibite - could you comment on @bvarner-ebi 's comment?

@dosumis
Copy link
Contributor

dosumis commented Oct 19, 2023

CC @cmungall

@cmungall
Copy link
Member

I agree with @bvarner-ebi's proposed changes

@paola-scibite
Copy link
Author

Thank you @bvarner-ebi , @dosumis and @cmungall . The proposed changes sound good to me too. Best wishes!

ghost pushed a commit that referenced this issue Nov 17, 2023
@ghost
Copy link

ghost commented Nov 17, 2023

Edits addressed in this issue:

@ghost ghost linked a pull request Nov 17, 2023 that will close this issue
@ghost ghost closed this as completed in #3119 Nov 21, 2023
ghost pushed a commit that referenced this issue Nov 21, 2023
Addresses #2225 Edit "lacrimal drainage system" terms
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants