Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uberon Editor SOP #2720

Merged
merged 7 commits into from
Mar 13, 2023
Merged

Uberon Editor SOP #2720

merged 7 commits into from
Mar 13, 2023

Conversation

shawntanzk
Copy link
Collaborator

@shawntanzk shawntanzk commented Nov 21, 2022

@dosumis - we need to discuss which of the relations to have in relations guide, the list is pretty long: https://docs.google.com/spreadsheets/d/1ScwOdD0KAphfmpBLZ9MMJa0jfkmH_uu-UoVEK7Vx2GQ/edit?usp=sharing

@shawntanzk shawntanzk self-assigned this Nov 21, 2022
@dosumis
Copy link
Contributor

dosumis commented Nov 21, 2022

110 if we remove duplicates due to multiple defs.

I think it would be really useful to generate a report as a starting point with relations grouped by position in OP hierarchy*, usage numbers and one example for each. We could generate from UberGraph. This would give us a nice summary of how Uberon is structured, showing where relations are used comprehensively vs spottily, as well as pointing to how to prioritise.

@anitacaron could take this on.

  • possible challenge comes from multiple inheritance in property graph, but I think that shouldn't be too hard to clean up by hand.

@anitacaron
Copy link
Collaborator

I can create two reports, one with the usage and an example and the other with the OP hierarchy. Then need to merge both manually.

@ghost ghost mentioned this pull request Dec 15, 2022
@shawntanzk
Copy link
Collaborator Author

@bvarner-ebi & @dosumis I've done a couple of relations for the guide, would like you to have a look first before I continue on in this format.
In regards to using the top few OP in the heirachy, they seem to point to similar uses, which can probably be squashed down or something? (Not sure about searching and all though). Maybe something to discuss in next docs meeting?

property p_label sub_property s_label
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0000122 in posterior side of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0000123 in anterior side of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0000124 in proximal side of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0000125 in distal side of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0000126 in lateral side of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0001100 in superficial part of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0001101 in deep part of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0001113 preaxialmost part of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0001115 postaxialmost part of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0005001 intersects midsagittal plane of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0015101 in dorsal side of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0015102 in ventral side of
http://purl.obolibrary.org/obo/BFO_0000050 part of http://purl.obolibrary.org/obo/BSPO_0020001 in central side of

@shawntanzk shawntanzk requested review from a user and dosumis January 3, 2023 12:23
@dosumis
Copy link
Contributor

dosumis commented Jan 3, 2023

Basic structure and content looks good. (The 'at all times; clause can be hard to commit to when representing development, but we can gloss that). I think it will be sufficient just to have @bvarner-ebi subedit for minor corrections.

The example of grouping relations using the hierarchy is exactly what I was looking for.

@shawntanzk
Copy link
Collaborator Author

Thanks @dosumis - will continue working in this way then
@bvarner-ebi let me work on some more relations first, ill ping you once I'm ready for you to subedit

@shawntanzk
Copy link
Collaborator Author

Could I propose that we start with what I have atm and continue working on the relations guide?

@shawntanzk shawntanzk changed the title [DO NOT MERGE] Uberon Editor SOP Uberon Editor SOP Jan 5, 2023
@shawntanzk
Copy link
Collaborator Author

@dosumis - am I right to say that the audience is someone who has ontology experience but needs to know the nuances of uberon?
@bvarner-ebi happy for you to change and edit anything directly, don't need to make suggestions etc.
Other than that I think this is ready for a first pass

Thanks

@shawntanzk shawntanzk marked this pull request as ready for review January 5, 2023 14:07
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

@shawntanzk shawntanzk assigned ghost and unassigned shawntanzk Feb 10, 2023
@shawntanzk
Copy link
Collaborator Author

@bvarner-ebi could you help see this through as part of docs work please. Thanks.

@github-actions
Copy link

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

Copy link
Contributor

@dosumis dosumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to merge. We can iteratively improve.

@dosumis dosumis merged commit f9c578a into master Mar 13, 2023
@dosumis dosumis deleted the uberon-editor-SOP branch March 13, 2023 12:41
@ghost ghost linked an issue Oct 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strategy for updating Relations Guide
3 participants