Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local logical axioms from simultaneous with #2830

Merged
merged 1 commit into from Mar 14, 2023

Conversation

anitacaron
Copy link
Collaborator

Part of the great cleasing. Context: #2453

@anitacaron anitacaron self-assigned this Feb 28, 2023
@anitacaron
Copy link
Collaborator Author

#gogoeditdiff

@anitacaron anitacaron requested a review from a user March 6, 2023 13:28
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anitacaron, from this comment....

  • back out the two subproperties in this PR, on reflection these are not correct
  • the corresponding injections should also be removed from uberon
  • make the relation symmetric
  • add the textual definition @dosumis proposes

Are the last two edits still required?

@anitacaron
Copy link
Collaborator Author

These were done in that PR. Here only get the reference.

@anitacaron anitacaron merged commit b51b512 into master Mar 14, 2023
@anitacaron anitacaron deleted the remove-ro-axiom branch April 11, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant