Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dup definitions: existence starts at point & existence ends at point #346

Closed
srobb1 opened this issue Jan 21, 2020 · 5 comments
Closed

dup definitions: existence starts at point & existence ends at point #346

srobb1 opened this issue Jan 21, 2020 · 5 comments
Labels
obsolete This includes both obsolete and merge requests

Comments

@srobb1
Copy link

srobb1 commented Jan 21, 2020

Hello,

I noticed that these two terms have the same def.

id label def
RO:0002583 existence starts at point x existence starts at point y if and only if the time point at which x starts is equivalent to the time point at which y ends.
RO:0002593 existence ends at point x existence starts at point y if and only if the time point at which x starts is equivalent to the time point at which y ends.

Would you like me to update and make a pull request? Though I am a bit confused by 'point at which y ends' part of the definition. How can x start at point y if y is ending?

Sofia

@phismith
Copy link

phismith commented Jan 21, 2020 via email

@srobb1
Copy link
Author

srobb1 commented Jan 22, 2020

I think that for

RO:0002583 existence starts at point

The definition could change:

from:
X existence starts at point y if and only if the time point at which x starts is equivalent to the time point at which y ends.

to:

  1. X existence starts at point y if and only if the time point at which x starts is equivalent to a time point after y begins and before y ends.

-or-

  1. X existence starts at point y if and only if the time point at which x starts is equivalent to a discrete time point which is y.

It seems that y should be a discrete instant, a single moment, and not a time range. If so, suggestion 2 fits better.

Sofia

@nlharris nlharris added the obsolete This includes both obsolete and merge requests label Oct 16, 2020
@nlharris
Copy link
Contributor

nlharris commented Jan 6, 2022

Is this still needed?

@cmungall
Copy link
Contributor

cmungall commented Jan 6, 2022

Fixed in #357

@cmungall cmungall closed this as completed Jan 6, 2022
@cmungall
Copy link
Contributor

cmungall commented Jan 6, 2022

the definitions are now distinct, and I believe formally correct, if a little formal. Open new issues/PRs for any further clarifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
obsolete This includes both obsolete and merge requests
Projects
None yet
Development

No branches or pull requests

4 participants