Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose a deduplicated ordinal domain #1813

Merged
merged 2 commits into from
Aug 16, 2023
Merged

expose a deduplicated ordinal domain #1813

merged 2 commits into from
Aug 16, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Aug 16, 2023

closes #1812

@Fil Fil requested a review from mbostock August 16, 2023 15:24
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to retrieve the domain back from the D3 scale; that way we don’t have to repeat the logic or risk it being inconsistent.

@mbostock mbostock enabled auto-merge (squash) August 16, 2023 15:49
@mbostock mbostock merged commit 76d4691 into main Aug 16, 2023
1 check passed
@mbostock mbostock deleted the fil/dedupe-domain branch August 16, 2023 15:51
Fil added a commit that referenced this pull request Aug 21, 2023
* expose a deduplicated ordinal domain

closes #1812

* use scale’s deduplicated domain

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* expose a deduplicated ordinal domain

closes observablehq#1812

* use scale’s deduplicated domain

---------

Co-authored-by: Mike Bostock <mbostock@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exposed ordinal scales should deduplicate the domain
2 participants