Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type the observable10 color scheme #1954

Merged
merged 2 commits into from
Dec 21, 2023
Merged

type the observable10 color scheme #1954

merged 2 commits into from
Dec 21, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Dec 21, 2023

No description provided.

@Fil Fil requested a review from mbostock December 21, 2023 11:45
mbostock
mbostock approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the categorical schemes in sorted order though?

@Fil
Update scales.d.ts
b695142 
order, fix comment
@Fil
Copy link
Contributor Author

Fil commented Dec 21, 2023

Fixed the order (plus, I had missed the comment!)

@Fil Fil enabled auto-merge (squash) December 21, 2023 14:30
@Fil Fil merged commit ae6dcef into main Dec 21, 2023
1 check passed
@Fil Fil deleted the fil/type-observable10-scheme branch December 21, 2023 14:31
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
@Fil @chaichontat
type the observable10 color scheme (observablehq#1954)
e2ee923 
* type the observable10 color scheme
* order, fix comment
@dperetti
Copy link

Weird, I get this upgrading from 0.6.13 to 0.6.14
image

@mbostock
Copy link
Member

@dperetti You need to upgrade your transitive dependencies (e.g., npm update).

This was referenced Jun 21, 2024
Open
Merged
@rizwan-r-r rizwan-r-r mentioned this pull request Jul 2, 2024
Merged
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 3, 2024
Open
@x-way x-way mentioned this pull request Jul 3, 2024
Closed
@rizwan-r-r rizwan-r-r mentioned this pull request Jul 3, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 4, 2024
Open
@rizwan-r-r rizwan-r-r mentioned this pull request Jul 4, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 5, 2024
Open
@rizwan-r-r rizwan-r-r mentioned this pull request Jul 5, 2024
Open
@apiiro-snyk apiiro-snyk mentioned this pull request Jul 5, 2024
Open
This was referenced Jul 6, 2024
Open
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 20, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 6, 2024
Open
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fil @dperetti @mbostock