-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume authorize_url from Secret #149
Conversation
The changes would need to be made in this file in the Telemeter repository: |
wondering what i'm doing wrong @metalmatze |
Updating all jsonnet dependencies broke the current jsonnet stack. |
@metalmatze care to take a look again? |
/retest |
I am still not sure if we really want this in our templates. @squat what do you think? |
We discussed with Maor a few weeks ago. It is not a change we like but, due to details/limitations of the saas-herder stack [1], it is required in order to enable deploying configmaps and other assets from outside of the app-interface repo. For that reason I think that the benefit outweighs the cost :/ [1] the tooling requires all https urls to be in a secret, as it incorrectly assumes that it is sensitive information. |
these changes are now in master, closing this one. EDIT: they are not, creating a replacement PR |
This PR intends to take the authorization URL out of the template and into the telemeter-server Secret.
Please let me know if you think this is a good idea!
Can you also point out where I'm missing a change in jsonnet?
Update: depends on openshift/telemeter#288
Thanks!