-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go config: Enhancements #548
Conversation
thibaultmg
commented
Jan 25, 2024
•
edited
Loading
edited
- Refactor k8sutil package into kubegen. It groups all sub-packages helping generating kube manifests. It could be easily exported into its own repository.
- Add init container support.
- Add Command field support to Container, useful when using some init containers.
- Refactor ConfigFile options to use an interface type, facilitating the use of init containers for dynamic config file generation.
- remove version label in objects where it is not needed (service, serviceMonitor, configMaps, secrets)
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Awesome job with the refactor, would love to see the kubegen
utils in their own repo!
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
The doc link is https://docs.google.com/document/d/1F9Cw6I4qFs__0Dcm19xvxJqRBCAGQBBggYg_PQSV_-g/edit#heading=h.cp0jmcyfj3 that is failing CI, can't access it without being logged in to gdoc. We can remove this in mdox, not an issue. Will merge this PR as is for now. It seems unrelated to the change you're trying to make. |