Performance drop in 2.0.0 release

[claremacrae]

Please check that this issue hasn't been reported before.

• I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

The following all work correctly in Tasks 1.25.0

Scenario 1

• Given an open note in Reading or Live Preview
  • That has one or more Tasks blocks in:
• When I edit any Task in my Vault
• Then each of those Tasks blocks should only be redrawn once

Scenario 2

• Given an open note in Reading or Live Preview
  • That has one or more Tasks blocks in:
• When I close the note
• Then edits to tasks in my vault should no longer trigger updates to the closed Tasks blocks

Current behaviour

The behavior in Tasks 2.0.0

Scenario 1

• Given an open note in Reading or Live Preview
  • That has one or more Tasks blocks in:
• When I edit any Task in my Vault
• Then each of those Tasks blocks is redrawn twice

Scenario 2

• Given an open note in Reading or Live Preview
  • That has one or more Tasks blocks in:
• When I close the note
• Then edits to tasks keep on updating the tasks blocks in closed files

Steps to reproduce

Tasks 1.25.0

• Open Obsidian with Tasks 1.25.0 enabled
• Open a note with a query in - in Reading
• Open a note a task in
• Open the console
• Toggle the task 2 or 3 times, and get a feeling for the appearance of the following types of message in the console:

At least one task, its line number or its heading has changed in ACME.md: triggering a refresh of all active Tasks blocks in Live Preview and Reading mode views.

Render tasks called for a block in active file "Test Query.md", to select from 606 tasks: plugin state: Warm

5 of 606 tasks displayed in a block in "Test Query.md"

• Then work through the Given/When/Then steps above

You will see the behaviour described above.

Tasks 2.0.0

Now repeat the above with 2.0.0, and you will see the same number of 'task has changed' messages - but a lot more 're-rendering' messages, even for files you have closed.

Which Operating Systems are you using?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

Obsidian Version

1.1.16

Tasks Plugin Version

2.0.0

Checks

• I have tried it with all other plugins disabled and the error still occurs

Possible solution

No response

[claremacrae]

I have done a git bisect and this log was:

git bisect start

• good: [0bd2d9a] Update to version 1.25.0
  git bisect good 0bd2d9a
• bad: [6fdc8f3] Update to version 2.0.0
  git bisect bad 6fdc8f3
• good: [f081d57] test: due date before quarter/year
  git bisect good f081d57
• bad: [941d8b0] Remove unused symbol declarations and regexes in src/Task.ts
  git bisect bad 941d8b0
• bad: [53c4bd4] Merge branch 'main' into searches-on-date-ranges
  git bisect bad 53c4bd4
• good: [092319b] test: add test for due in two weeks
  git bisect good 092319b
• good: [292defb] tests: add more tests for createdDate based on review
  git bisect good 292defb
• good: [60a4789] fix: buildFilterFunction() description for JSdocs
  git bisect good 60a4789
• good: [8ed52a9] docs: Minor consistency edits and formatting fix
  git bisect good 8ed52a9
• bad: [94d4f69] Merge pull request feat: add created date to task #1723 from vanadium23/feature-task-created-date
  git bisect bad 94d4f69
• bad: [d7593a2] fix: render in canvas (fix: render Tasks in canvas #1733)
  git bisect bad d7593a2
• first bad commit: [d7593a2] fix: render in canvas (fix: render Tasks in canvas #1733)

Reverting d7593a2 does fix the problem.

[claremacrae]

I've asked for advice in Discord.
https://discord.com/channels/686053708261228577/840286264964022302/1088950909293314162

No replies yet.

[claremacrae]

@ilandikov - For your information... Sorry to be the bearer of this news, and really sorry that I did not spot it in testing the fix for #1732.

This is the source of the big slow-down in editing in 2.0.0 that I mentioned...

@gypsyav - We will need to try and find a fix for the canvas bug that doesn't hit the Tasks rendering efficiency.

Otherwise, sadly, I think I may need to do a bug-fix release in the next day or two that reverts the slow-down.

[ilandikov]

Oh wow. Well the fix was inspired by blacksmithgu/obsidian-dataview#1661
I wonder why that didn't (?) slow the dataview plugin down.

In the meantime it is definitely worth it to revert the bug fix.

[claremacrae]

I had the same thought, and let the dataview author know in Discord that it would be worth checking if it does.

The Dataview code is a lot more optimised for speed than Tasks, so there could be something else there that prevents wasted redraws, for example.