'When done' causing wrong done date

[Azurewren]

Please check that this issue hasn't been reported before.

• I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

When I check the below task as done by clicking the check field, it should add today's done date (2024-05-31) and create the recurring task.

- [ ] 🦷 Dentist Check up Appointment 🔁 every 6 months when done ⏳ 2024-05-31

which would turn into:

- [x] 🦷 Dentist Check up Appointment 🔁 every 6 months when done ⏳ 2024-05-31 ✅ 2024-05-31
- [ ] 🦷 Dentist Check up Appointment 🔁 every 6 months when done ➕ 2024-05-31 ⏳ 2024-11-30

Current behaviour

When checked, the task adds yesterday as it's completion date instead.

- [x] 🦷 Dentist Check up Appointment 🔁 every 6 months when done ⏳ 2024-05-31 ✅ 2024-05-30
- [ ] 🦷 Dentist Check up Appointment 🔁 every 6 months when done ➕ 2024-05-31 ⏳ 2024-11-30

I have tried it without the 'when done' words in the recurrence rule and it works correctly.

Steps to reproduce

1. I have been able to reproduce this in sandbox vault with only Tasks installed

Maintainer's note: See #2867 (comment) for reproduction steps.

Which Operating Systems are you using?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

Obsidian Version

1.6.1 (Insider Release), Installer version 1.5.3

Tasks Plugin Version

7.3.0

Checks

• I have tried it with all other plugins disabled and the error still occurs

Possible solution

No response

[claremacrae]

What time zone was the computer/device set to?

What time of day did you observe the problem?

[claremacrae]

First thought: I am wondering whether this might be the underlying cause:

• Data in Task and TasksDate are accidentally mutable - dates can be edited unintentionally #2866

Perhaps some calculation involved in the ‘when done’ code is unintentionally editing a date value.

A test would need to written to demonstrate the problem behaviour - hence asking for time and time zone info.

[Azurewren]

What time zone was the computer/device set to?

What time of day did you observe the problem?

I am in +0800 timezone (Perth/Australia) and it was about 2pm in the afternoon.

Trying it in a sandbox vault today (2024-06-01, ~10.30am, same timezone above) and apparently it has decided to work correctly.

I wonder if there is a problematic connection between the Recurrence Date of the newly created task and the Completion date of the old task?

[claremacrae]

Thanks, I did wonder... It seems to be the only time-zone that features regularly...

• Completing a daily recurring task creates task set to same day [the day before Australian clocks switch to daylight savings] #2309
• Recurring Task 'every day' gets stuck at the end of a month [the day before Australian clocks switch to daylight savings] #1200

[claremacrae]

Steps to reproduce

1. I have been able to reproduce this in sandbox vault with only Tasks installed

For future reference, it really helps with development if there are actual steps listed to reproduce the bug, instead of having to gather information from other parts of the ticket....

[claremacrae]

Steps to reproduce

1. Install and enable the Tasks plugin (tested with Tasks 7.5.0)
2. Edit the Tasks settings:
   • Enable 'Next recurrence appears on the line below'
3. Paste the following line in to any Markdown note:

- [ ] #task 🦷 Dentist Check up Appointment ⏳ 2024-05-31 🔁 every 6 months when done

4. Put the cursor in that line and run Tasks: Create or edit task
   • Change the status to Done
   • Paste 2024-05-31 in to the Done date field
   • Click Apply

Expected result:

• #task 🦷 Dentist Check up Appointment 🔁 every 6 months when done ⏳ 2024-05-31 ✅ 2024-05-31
• #task 🦷 Dentist Check up Appointment 🔁 every 6 months when done ⏳ 2024-11-30

The Done date should be ✅ 2024-05-31, which is the supplied value.

Actual result:

• #task 🦷 Dentist Check up Appointment 🔁 every 6 months when done ⏳ 2024-05-31 ✅ 2024-05-30
• #task 🦷 Dentist Check up Appointment 🔁 every 6 months when done ⏳ 2024-11-30

The Done date is a day earlier than the specified value.

Note:

Repeating with this line gives the correct result:

- [ ] #task 🦷 Dentist Check up Appointment ⏳ 2024-05-31 🔁 every 6 months

Removing the when done gives the correct result in this case.

[claremacrae]

Thanks, I did wonder... It seems to be the only time-zone that features regularly...

• Completing a daily recurring task creates task set to same day [the day before Australian clocks switch to daylight savings] #2309
• Recurring Task 'every day' gets stuck at the end of a month [the day before Australian clocks switch to daylight savings] #1200

It doesn't depend on timezone after all...

I can reproduce it in UTC and Current UK (BST) time zones.

I am now pretty sure the cause is an instance of this:

• Data in Task and TasksDate are accidentally mutable - dates can be edited unintentionally #2866

[claremacrae]

Hi @Azurewren, huge thanks for reporting this!

It will be fixed in the next release....

[claremacrae]

Just released in Tasks 7.6.0.