Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 'explain' shows Continuations and Placeholders for filters #2711

Merged
merged 17 commits into from
Mar 16, 2024
Merged

feat: 'explain' shows Continuations and Placeholders for filters #2711

merged 17 commits into from
Mar 16, 2024

Commits on Mar 16, 2024

  1. refactor: . Extract variable instruction in Filter.explainFilterInden… 

    …ted()
    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    b5b7094 View commit details
    Browse the repository at this point in the history

  2. refactor: - Extract function explainStatement()

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    362ac31 View commit details
    Browse the repository at this point in the history

  3. refactor: - Introduce Statement.explainStatement()

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    7473b5f View commit details
    Browse the repository at this point in the history

  4. refactor: . Inline explainStatement()

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    6ef9132 View commit details
    Browse the repository at this point in the history

  5. feat: 'explain' now shows effect of placeholders 

    See #2349: Make 'explain' show the effect of Line Continuations and Placeholders
    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    559bd37 View commit details
    Browse the repository at this point in the history

  6. refactor: - Extract appendLineIfDifferent()

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    a11bfca View commit details
    Browse the repository at this point in the history

  7. feat: 'explain' now shows effect of continuations. 

    See #2349: Make 'explain' show the effect of Line Continuations and Placeholders
    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    1e24d7e View commit details
    Browse the repository at this point in the history

  8. fix: Retain any original indentation when explaining continuations

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    93efe7b View commit details
    Browse the repository at this point in the history

  9. fix: When explaining multi-line statements, put '=>' on next line for… 

    … visibility
    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    cd0ae50 View commit details
    Browse the repository at this point in the history

  10. test: - Show how explanations work with extra spaces around instructions

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    a801d73 View commit details
    Browse the repository at this point in the history

  11. test: - Add test showing output of sort line with continuations

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    bfd35e4 View commit details
    Browse the repository at this point in the history

  12. refactor: - Extract appendLineIfDifferent()

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    a434282 View commit details
    Browse the repository at this point in the history

  13. test: - Add test showing output of group line with continuations

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    c6a0cf4 View commit details
    Browse the repository at this point in the history

  14. fix: Tidy up 'explain' output for instructions surrounded by whitespace

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    ca2b87c View commit details
    Browse the repository at this point in the history

  15. refactor: . Clarify variable name: instruction -> explainedStatement

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    3135947 View commit details
    Browse the repository at this point in the history

  16. docs: Update snippets with the now more-detailed explanations

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    8bd9557 View commit details
    Browse the repository at this point in the history

  17. comment: Add some TODOs in Explainer.test.ts

    @claremacrae
    claremacrae committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    0c30df9 View commit details
    Browse the repository at this point in the history