Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'explain' shows Continuations and Placeholders for filters #2711

Merged
merged 17 commits into from Mar 16, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

The explain instruction now successfully explains Continuations and Placeholders for filter lines.

Motivation and Context

See #2349 - for which this is a partial solution.

Still to do: explanations of Continuations and Placeholders for sort by function and group by function.

How has this been tested?

  • New tests
  • Lots of exploratory testing

Screenshots (if appropriate)

Changes in the documentation:

image

Types of changes

Changes visible to users:

  • New feature (prefix: feat - non-breaking change which adds functionality)
  • Documentation (prefix: docs - improvements to any documentation content for users)

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

Terms

@claremacrae claremacrae added scope: filters Additions and modifications to the search filters scope: explain About the `explain` instruction which generates explanations of tasks query blocks labels Mar 16, 2024
@claremacrae claremacrae merged commit e32ebbc into main Mar 16, 2024
2 checks passed
@claremacrae claremacrae deleted the better-explain-filters branch March 16, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: explain About the `explain` instruction which generates explanations of tasks query blocks scope: filters Additions and modifications to the search filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant