Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Start new code for preprocessing Boolean instructions #2756

Merged
merged 19 commits into from Apr 8, 2024
Merged

refactor: Start new code for preprocessing Boolean instructions #2756

merged 19 commits into from Apr 8, 2024

Conversation

claremacrae
Copy link
Collaborator

Description

  • TDD the creation of BooleanPreprocessor.splitLine()

I'm calling this a refactoring as the code is not yet used in the plugin, so there is no visible change in behaviour.

Motivation and Context

Working towards fixing:

How has this been tested?

  • Automated tests only, as code is not yet used in the plugin

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae
refactor: - New class BooleanPreprocessor now recognises AND
09da976 
This is the start of rewriting the parsing of Boolean instructions
@claremacrae
refactor: - Recognise ) OR (
329829c
@claremacrae
refactor: - Recognise ) XOR (
08d8e5c
@claremacrae
refactor: - Recognise ) AND NOT (
6da284b
@claremacrae
refactor: - Recognise ) OR NOT (
eeb34db
@claremacrae
refactor: - Allow extra spaces in between AND/OR and NOT
c64bba2
@claremacrae
refactor: - Allow missing spaces around the operator
4aad1ee 
This is for consistency with the parsing in the current implementation.
Later, boon-js will insist that spaces are present, but we make the parsing
more relaxed.
@claremacrae
comment: Add explanatory comments
59f8f0b
@claremacrae
test: Add test to visualise behaviour of BooleanPreprocessor.splitLine()
62f313f
@claremacrae
refactor: - Handle lines starting NOT (
e260535
@claremacrae
refactor: - Filter out empty values
59c208b
@claremacrae
test: - Divide up tests with describe blocks, for readability
2cb9cac
@claremacrae
test: . Snapshots reformatted by jest, after code indented
97b9311
@claremacrae
refactor: - Handle variable spaces between NOT and its opening delimiter
95d29f8
@claremacrae
refactor: - Remove global flax on regexes, which turned out not to be…
ab69b07 
… needed
@claremacrae
refactor: - Separate delimiters and spaces from the start of filters
1f15ddc
@claremacrae
refactor: - Separate delimiters and spaces from the end of filters
b258226
@claremacrae
comment: fix vocabulary: delimiters, not parentheses
5323e16
@claremacrae
refactor: . fix vocabulary: delimiters, not parentheses
3831603
@claremacrae claremacrae added type: internal Only regards development or contributing scope: query logic Boolean combinations of filters - and, or, not labels Apr 8, 2024
@claremacrae claremacrae merged commit cd9f5dd into main Apr 8, 2024
2 checks passed
@claremacrae claremacrae deleted the refactor-boolean-preprocessor-split branch April 8, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: query logic Boolean combinations of filters - and, or, not type: internal Only regards development or contributing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@claremacrae