Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Start new code for preprocessing Boolean instructions #2756

Merged
merged 19 commits into from Apr 8, 2024
Merged

refactor: Start new code for preprocessing Boolean instructions #2756

merged 19 commits into from Apr 8, 2024

Commits on Apr 8, 2024

  1. refactor: - New class BooleanPreprocessor now recognises AND 

    This is the start of rewriting the parsing of Boolean instructions
    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    09da976 View commit details
    Browse the repository at this point in the history

  2. refactor: - Recognise ) OR (

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    329829c View commit details
    Browse the repository at this point in the history

  3. refactor: - Recognise ) XOR (

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    08d8e5c View commit details
    Browse the repository at this point in the history

  4. refactor: - Recognise ) AND NOT (

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6da284b View commit details
    Browse the repository at this point in the history

  5. refactor: - Recognise ) OR NOT (

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    eeb34db View commit details
    Browse the repository at this point in the history

  6. refactor: - Allow extra spaces in between AND/OR and NOT

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c64bba2 View commit details
    Browse the repository at this point in the history

  7. refactor: - Allow missing spaces around the operator 

    This is for consistency with the parsing in the current implementation.
Later, boon-js will insist that spaces are present, but we make the parsing
more relaxed.
    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4aad1ee View commit details
    Browse the repository at this point in the history

  8. comment: Add explanatory comments

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    59f8f0b View commit details
    Browse the repository at this point in the history

  9. test: Add test to visualise behaviour of BooleanPreprocessor.splitLine()

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    62f313f View commit details
    Browse the repository at this point in the history

  10. refactor: - Handle lines starting NOT (

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e260535 View commit details
    Browse the repository at this point in the history

  11. refactor: - Filter out empty values

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    59c208b View commit details
    Browse the repository at this point in the history

  12. test: - Divide up tests with describe blocks, for readability

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    2cb9cac View commit details
    Browse the repository at this point in the history

  13. test: . Snapshots reformatted by jest, after code indented

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    97b9311 View commit details
    Browse the repository at this point in the history

  14. refactor: - Handle variable spaces between NOT and its opening delimiter

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    95d29f8 View commit details
    Browse the repository at this point in the history

  15. refactor: - Remove global flax on regexes, which turned out not to be… 

    … needed
    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    ab69b07 View commit details
    Browse the repository at this point in the history

  16. refactor: - Separate delimiters and spaces from the start of filters

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1f15ddc View commit details
    Browse the repository at this point in the history

  17. refactor: - Separate delimiters and spaces from the end of filters

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b258226 View commit details
    Browse the repository at this point in the history

  18. comment: fix vocabulary: delimiters, not parentheses

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5323e16 View commit details
    Browse the repository at this point in the history

  19. refactor: . fix vocabulary: delimiters, not parentheses

    @claremacrae
    claremacrae committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3831603 View commit details
    Browse the repository at this point in the history