Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align the look of Priority section in task modal with date sections #2794

Merged

Conversation

ilandikov
Copy link
Collaborator

Description

In Priority section:

  • Use color from the Obsidian for the checked radio button (Default blue -> Obsidian violet, like the checkbox for "Only future dates")
  • Align the grid that positions the priority values with the date sections

Motivation and Context

Consistent look the edit task modal.

How has this been tested?

Visual test in demo vault.

Screenshots (if appropriate)

Before After
Снимок экрана 2024-05-01 в 23 56 00 Снимок экрана 2024-05-01 в 23 59 56

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.
    • no unit test for CSS code

Terms

@ilandikov
Copy link
Collaborator Author

I wrote the commits as feat but when creating the PR realised they are more of a fix so the PR is a fix. I can change the commit messages to fix as well and force push the branch if you prefer.

@claremacrae claremacrae added the scope: edit task The Create or edit task modal/dialog label May 1, 2024
Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@claremacrae claremacrae merged commit f28f9b8 into obsidian-tasks-group:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants