Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove background under the dependency delete button #2835

Merged

Conversation

ilandikov
Copy link
Collaborator

Description

The change is seen only on the dark theme.

Before

Снимок экрана 2024-05-18 в 17 36 02

After (Note the background under the "x" is gone)

Снимок экрана 2024-05-18 в 17 46 52

On the clear theme the is no change in color, only the shape slightly changed. After:

Снимок экрана 2024-05-18 в 17 37 57

Motivation and Context

  • have a prettier task modal =)

How has this been tested?

  • manual test in demo valuet

Screenshots (if appropriate)

Types of changes

Changes visible to users:

  • Bug fix (prefix: fix - non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

(I don't consider this a big enough change to update the modal screenshot)

Terms

@ilandikov ilandikov added the scope: edit task The Create or edit task modal/dialog label May 18, 2024
Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally feel that having the visible difference around the x in dark mode made the behaviour clearer - that is, make it obvious that the x was not a part of the preceding text - but I don't mind enough to spend any time debating it...

Approving and merging.

@claremacrae claremacrae merged commit 0fbc34a into obsidian-tasks-group:main May 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants