Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests of Obsidian cache with labelled callouts #2905

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Jun 21, 2024

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

This does confirm that 1.6.4 could fix #2890 - but only if the user knows that they need to force the Obsidian cache to be updated.

Motivation and Context

Goal: to demonstrate that Obsidian 1.6.4 really did #2890.

It turned out that I had to first make an edit to each of the affected files with callouts that have labels, in order for Obsidian to update its cache.

How has this been tested?

By automated tests.

Screenshots (if appropriate)

Checklist

Terms

2 tests that use labelled callouts are failing, due to an Obsidian bug. See #2863
…outs

This required forcing Obsidian to regenerate its cache for the following files,
by editing them, so its fix for its cause of #2890:

- callout_labelled.md
- callouts_nested_issue_2890_labelled.md
@claremacrae claremacrae added type: internal Only regards development or contributing scope: callouts Issues with tasks or searches in Obsidian Callouts labels Jun 21, 2024
@claremacrae claremacrae changed the title test: Add tests of Obsidian cache with labelled callouts - see #2890 test: Add tests of Obsidian cache with labelled callouts Jun 21, 2024
@claremacrae claremacrae merged commit 66140f6 into main Jun 21, 2024
2 checks passed
@claremacrae claremacrae deleted the test-nested-callouts branch June 21, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: callouts Issues with tasks or searches in Obsidian Callouts type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Tasks in Titled Callouts – Obsidian v1.6.0 to v1.6.4 [fixed by making v1.6.5 recreate its cache]
1 participant