Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: demo property custom searches #2981

Conversation

ilandikov
Copy link
Collaborator

@ilandikov ilandikov commented Jul 22, 2024

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

  • done by pairing with @claremacrae
  • add test showing current behaviour of access to task.file.frontmatter

Motivation and Context

  • prepare release with FrontMatter access

How has this been tested?

  • approval test

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@claremacrae claremacrae added the type: internal Only regards development or contributing label Jul 22, 2024
@claremacrae
Copy link
Collaborator

Thanks!

SonarCloud is complaining about some duplicated code, but this is a pre-existing pattern, and not something that needs fixing in this PR, so I am going to merge anyway.

1 similar comment
@claremacrae
Copy link
Collaborator

Thanks!

SonarCloud is complaining about some duplicated code, but this is a pre-existing pattern, and not something that needs fixing in this PR, so I am going to merge anyway.

@claremacrae claremacrae merged commit e633aec into obsidian-tasks-group:main Jul 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants