Don't remove KAFKA_PROPERTIES_FILE; allow user to use mounted file #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change gives users the option to put their _own_ `KAFKA_PROPERTIES_FILE` into an image _without_ specifying `KAFKA_PROPERTIES`. This is particularly useful in cases where a user does not want to store `KAFKA_PROPERTIES` in version control such as Git. (Even though it is base64-encoded, it is not encrypted.)
Bert-R
reviewed
Apr 7, 2023
There was a problem hiding this comment.
Good addition!
Can you update the README.md and add an alternative docker run where the Kafka properties file is mounted in read-only?
Something like this:
docker run -d --rm -p 9000:9000 \
-v $(pwd)/kafka.properties:/tmp/kafka.properties:ro \
-e KAFKA_BROKERCONNECT=<host:port,host:port> \
-e KAFKA_PROPERTIES_FILE=/tmp/kafka.properties \
-e KAFKA_TRUSTSTORE="$(cat kafka.truststore.jks | base64)" \ # optional
-e KAFKA_KEYSTORE="$(cat kafka.keystore.jks | base64)" \ # optional
obsidiandynamics/kafdrop
brsolomon-deloitte
changed the title
Added. |
Bert-R
reviewed
Apr 7, 2023
Bert-R
reviewed
Apr 7, 2023
Co-authored-by: Bert Roos <Bert-R@users.noreply.github.com>
Bert-R
added a commit
that referenced
this pull request
Oct 28, 2023
Earlier, we used to delete the following files if existing: * kafka.properties * kafka.truststore.jks * kafka.keystore.jks Since #502, we are creating them if not existing. With this commit, we take the middle ground: let the user decide about the existence.
This was referenced Oct 28, 2023
Bert-R
added a commit
that referenced
this pull request
Oct 30, 2023
Earlier, we used to delete the following files if existing: * kafka.properties * kafka.truststore.jks * kafka.keystore.jks Since #502, we are creating them if not existing. With this commit, we take the middle ground: let the user decide about the existence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives users the option to put their own
KAFKA_PROPERTIES_FILEinto an image without specifyingKAFKA_PROPERTIES.This is particularly useful in cases where a user does not want to store
KAFKA_PROPERTIESin version control such as Git. (Even though it is base64-encoded, it is not encrypted.)