Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't touch keystore or it will try and use it #583

Closed
wants to merge 1 commit into from
Closed

don't touch keystore or it will try and use it #583

wants to merge 1 commit into from

Conversation

msillence
Copy link

@msillence
Copy link
Author

Looking at the commit that brought this in: d563606#diff-832ab3de2c8910a0a2d9f4fe4827e9a1ccde40835d416f3d7f89cb806d4226bfL59

I guess we could touch them if the env is set but defaulting it and setting it seems to cause problems
I'm not sure we should

@Bert-R
Copy link
Collaborator

Bert-R commented Oct 28, 2023

Sorry for not getting to this earlier, but I don't think this is the right fix. The issue that #502 wanted to address is that the config files were deleted. Instead of just not deleting them, moved to creating them. Now I created #584 to leave the files untouched. If they exist, they won't be deleted. If they don't exist, they won't be created, unless the content of the files is provided through environment variables.

@Bert-R
Copy link
Collaborator

Bert-R commented Nov 2, 2023

This is fixed in a slightly different way through #584. It's now available in release 4.0.1

@Bert-R Bert-R closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msillence @Bert-R