Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Notes: Drawings not imported #134

Closed
kepano opened this issue Oct 17, 2023 · 11 comments · Fixed by #137
Closed

Apple Notes: Drawings not imported #134

kepano opened this issue Oct 17, 2023 · 11 comments · Fixed by #137
Labels
bug Something isn't working

Comments

@kepano
Copy link
Collaborator

kepano commented Oct 17, 2023

Drawings in imported Apple Notes show the following error

**(error reading attachment)**

We should try to import/convert the drawing, or display a more useful error

@kepano kepano added the bug Something isn't working label Oct 17, 2023
@kepano
Copy link
Collaborator Author

kepano commented Oct 17, 2023

@mirnovov what is the storage format for drawings?

@kepano kepano changed the title Apple Notes: Drawings not supported Apple Notes: Drawings not imported Oct 17, 2023
@mirnovov
Copy link
Contributor

mirnovov commented Oct 17, 2023

Drawings are stored as a format containing their lines etc, similar to SVG. However, a fallback image is generated, which this importer uses. I believe I've found a bug where the path for this image is resolved incorrectly which will probably fix this issue.

btw @kepano what macOS and iOS versions are you on? and were your drawings and scans created on those versions, or earlier? since the exact location of the data for those depends on which version the note was created on (iOS 17 and later changes things up with ZGENERATION etc.)

@kepano
Copy link
Collaborator Author

kepano commented Oct 18, 2023

In my test I used iOS 17.0.3 to create the drawing, then synced it to my Mac running macOS 13.0.1 before importing.

@mirnovov
Copy link
Contributor

Thanks. In that case, I think it will possibly be fixed by this PR, since the changes to the drawing location are made in macOS 14/iOS 17.

@rubenIGM
Copy link

Hi guys, unfortunately this problem persists, iOS 16.7.5 and Ventura 13.4. the drawings fail to import.

@andrewcrook
Copy link

I have also written some notes about this here

I think the issue is to do with old notes like #137 . If I clean out notes and create new notes it works fine.
It seems to me to have something to do with the ZIDIDENTIFIER in the notes db, unformantly I no longer have any old notes to look at in the db.

@rubenIGM
Copy link

Ok strange as none of my notes import…also recent ones.

@mbewley
Copy link

mbewley commented Feb 25, 2024

Have been using apple notes on the iPad over the years with apple pencil/handwriting. I get these errors on every note with handwriting:

Failed: "" because Cannot read properties of undefined (reading 'ZIDENTIFIER')

Newer notes seem to get imported, but with " (error reading attachment)" instead of the chunk of handwriting.
Older notes are raised as a "failed" import note with the ZIDENTIFIER error above, and the entire note is empty, even if it was a mix of handwriting and plain text.

Anything I can do to help troubleshoot?

@andrewcrook
Copy link

I am thinking if there are two separate issues here?

ZIDENTIFIER with old notes

and the other, I wonder it has something to do with the fact that there are currently two iCloud modes normal and advanced data protection?

Screenshot 2024-02-25 at 17 50 22

@mbewley
Copy link

mbewley commented Feb 26, 2024

I'm certainly seeing the issues above without advanced data protection.

@tommasodiotalevi
Copy link

I also have a similar issue: I tried to import my Apple notes, and I receive the following failure:

...
Failed: "DATASET NAME RULE" because Cannot read properties of undefined (reading 'ZIDENTIFIER')
...

In these notes, I have text alternated to text drawings made with the Apple pencil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants