Apple Notes: Fix older drawings, scans, and a few other things #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirnovov
changed the title
This method isn't documented in sqlite-tag-spawned hence why i missed it earlier
mirnovov
changed the title
mirnovov
changed the title
|
I can confirm that #135 is resolved — importing scans works for me now. However #134 is not solved under the conditions I described in the issue
I am still getting the same text inside the note |
tgrosinger
reviewed
Oct 18, 2023
tgrosinger
reviewed
Oct 18, 2023
|
@kepano Should be fixed now, I've spent the morning setting up a test vault on an older version of macOS and managed to reproduce the issue. |
|
Beautiful! Drawings are working for me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #134 and possibly fixes #135
Fixes the importer being unable to find the location of the drawing fallback image under certain circumstances (definitely pre-iOS 17 but a
ZGENERATIONmay not be generated under other circumstances as well).Fixes scans not being generated when the nicely cropped version of the image can't be found, by finding the camera photo and using that. (The cropped and flattened version may be stored somewhere else for older note versions but I never used the scan functionality before testing this, and the other Apple Notes importers just always use the camera photo so I can't see what they do. So short of me downgrading to an old macOS and iOS version I won't be able to determine that)
This also includes a few minor patches that didn't quite make it in #125