Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add obsidian-dida-sync #2193

Merged
merged 6 commits into from
Aug 15, 2023
Merged

add obsidian-dida-sync #2193

merged 6 commits into from
Aug 15, 2023

Conversation

eightHundreds
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin:https://github.com/eightHundreds/obsidian-dida-sync

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@liamcain
Copy link
Collaborator

  • executeCommandById instead of calling executeCommandById, you could just put the sync code into a function and call that directly

@liamcain liamcain merged commit 2f00b26 into obsidianmd:master Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants