Simplify everything by making Has into the class, and getting rid of … #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the ConstraintsFor type family
3noch
reviewed
Jul 9, 2020
3noch
reviewed
Jul 9, 2020
3noch
reviewed
Jul 9, 2020
|
I'm happy to report that lambdabot (which uses constraints-extras via dependent-sum) can still be compiled with this change. This is kind of expected. Code that relies only on |
|
I don't like this change, there is fancy stuff I want to do with quantified constraints that this will break. The sort of thing I started implementing in #17. |
# Conflicts: # src/Data/Constraint/Extras.hs # src/Data/Constraint/Extras/TH.hs This merge also involved a bunch of re-documentation and I extended the README to test the code for handling type families.
endgame
reviewed
Aug 19, 2020
|
|
||
| -- | \"Primed\" variants (@ConstraintsFor'@, 'argDict'', 'Has'', |
There was a problem hiding this comment.
Although ConstraintsFor' goes away, it might be nice to say what "primed" variants and "V" variants of things mean.
There was a problem hiding this comment.
I do, just in the documentation for those things. But I can document this type synonym as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the ConstraintsFor type family