Sample app using ckb-sdk-js. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it appears that the recoverable signature bug in speculos is not adequately addressed yet, change the default to be running against the live hardware and add an explanation.
jhartzell42
requested changes
Aug 19, 2020
| const CKB = require('../lib').default | ||
| const formatter = require('../../ckb-sdk-rpc/lib/paramsFormatter').default | ||
|
|
||
| // Note: there is currently a speculos bug that appears not to have been |
There was a problem hiding this comment.
This note should be written in such a way that someone trying to use this app, who doesn't know at all what Speculos is, does not think there's a serious bug.
There was a problem hiding this comment.
Updated to be clearer on what useSpeculos is/does to make the caveat make more sense.
jhartzell42
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.