Skip to content

Commit

Permalink
Fix configure.ac rapidcheck tests
Browse files Browse the repository at this point in the history
- `AC_LANG_PUSH(C++)` is needed for the header check

- The library check is hopeless (without lots of third-party macros I
  don't feel like getting) because name mangling

Pkg-config would make all this easier. I previously opened
emil-e/rapidcheck#302, I should write a PR
too.
  • Loading branch information
Ericson2314 committed Jan 30, 2023
1 parent a31d7d4 commit 16fa8c2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,11 @@ PKG_CHECK_MODULES([GTEST], [gtest_main])

# Look for rapidcheck.
# No pkg-config yet, https://github.com/emil-e/rapidcheck/issues/302
AC_LANG_PUSH(C++)
AC_CHECK_HEADERS([rapidcheck/gtest.h], [], [], [#include <gtest/gtest.h>])
AC_CHECK_LIB([rapidcheck], [])
dnl No good for C++ libs with mangled symbols
dnl AC_CHECK_LIB([rapidcheck], [])
AC_LANG_POP(C++)


# Look for nlohmann/json.
Expand Down

0 comments on commit 16fa8c2

Please sign in to comment.