Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pkg-config file? #302

Closed
Ericson2314 opened this issue Jan 18, 2023 · 3 comments
Closed

Add pkg-config file? #302

Ericson2314 opened this issue Jan 18, 2023 · 3 comments

Comments

@Ericson2314
Copy link

This would be convenient for downstream usage. Is this something a PR would be accepted for?
@Ericson2314 Ericson2314 mentioned this issue Jan 25, 2023
Merged
7 tasks
Ericson2314 added a commit to obsidiansystems/nix that referenced this issue Jan 30, 2023
@Ericson2314
Fix configure.ac rapidcheck tests
16fa8c2 
- `AC_LANG_PUSH(C++)` is needed for the header check

- The library check is hopeless (without lots of third-party macros I
  don't feel like getting) because name mangling

Pkg-config would make all this easier. I previously opened
emil-e/rapidcheck#302, I should write a PR
too.
@Ericson2314 Ericson2314 mentioned this issue Jan 30, 2023
Merged
7 tasks
@Ericson2314 Ericson2314 mentioned this issue Mar 16, 2023
Open
@roberth roberth mentioned this issue Aug 16, 2023
Open
8 tasks
@Ericson2314
Copy link
Author

Bump. If this is approved, I would be happy to contribute it. We can create these from CMake it's not a problem.

@Ericson2314
Copy link
Author

This is the one example I know off hand of making/installing a .pc file in CMake.

https://github.com/llvm/llvm-project/blob/7e0c5266309c1d2a0e6d766834415dff5cb65e47/libclc/CMakeLists.txt#L158

https://github.com/llvm/llvm-project/blob/7e0c5266309c1d2a0e6d766834415dff5cb65e47/libclc/libclc.pc.in

@Ericson2314
Copy link
Author

Now fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ericson2314